This repository has been archived by the owner on Sep 2, 2021. It is now read-only.
Don't DrawMenuBar() for every menu item #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
looks good |
JeffryBooher
added a commit
that referenced
this pull request
Nov 12, 2013
Don't DrawMenuBar() for every menu item
JeffryBooher
added a commit
that referenced
this pull request
Dec 8, 2015
Don't DrawMenuBar() for every menu item
This was referenced Aug 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't seem to be necessary to
DrawMenuBar()on every menu item as it's added on Windows.SetMenuTitle()already sets a time to do that.This seems to reduce start up time by ~3/4 second on my lenovo W510 running Win7. Also draws all core menus in menubar at once, followed by a second draw for extensions. Currently, the only extension that adds a menu it the builtin Debug menu, so this should be tested with other extensions that add menus (e.g. Emmet).
This is for adobe/brackets#5266, but there may be more that can be done.
Windows-only.