This repository has been archived by the owner on Sep 2, 2021. It is now read-only.
Fix chrome launching problems #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ackets-shell into randy/starting-live-dev
|
I'm seeing a bug with this change:
At step 4, the file is opened in the original Chrome window from Step 0, and not the Chrome window from step 1. Brackets shows the "Connecting to Browser" error dialog. Clicking "Relaunch Chrome" closes both windows. |
|
Ignore the previous comment -- I didn't have the |
ghost
assigned
|
Glad you got the first launch problem solved! Merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for adobe/brackets#2370
This adds a new launch flag so chrome uses a different profile on Window. This causes Chrome to open a separate window for brackets Live Preview connections which avoids debugging flag conflicts.
This didn't seem to have any effect on Mac, so it wasn't added.
There is an associated randy/starting-live-dev branch on brackets.