-
Notifications
You must be signed in to change notification settings - Fork 25
Incorporating changes for the brackets-registry redesign #82
base: master
Are you sure you want to change the base?
Conversation
README.md
Outdated
|
||
- Requirements | ||
- Git command line tools — follow the setup instructions on [GitHub](https://help.github.com/articles/set-up-git) or download [here](http://git-scm.com/downloads) | ||
- [NodeJS installed](https://nodejs.org/en/download/current/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mention the node version. The current version might break some features in the future.
public/img/LICENSE.txt
Outdated
to represent the company, product, or service to which they refer.** | ||
|
||
################################################################################# | ||
Modified by Adobe Systems Incorporated 2017. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2018?
@@ -0,0 +1,118 @@ | |||
<!-- Header Section --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i assume this is the new page that you have added.Is the registry site localized ? if yes, this new page should support localization for the same set of languages that the original registry site supports.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Registry page doesn't support localization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you run linting for all the changes here in this review?
We have an automatic lint checker, that can be accessed via running "npm run lint". Linting test passed. |
This PR includes the registry side changes that were done as part of the brackets website redesign.
This covers:
SIte can be visually reviewed at https://54.245.134.35
ping @nethip and @swmitra for review.