Actions Metrics Server: Use timestamps from Workflow Job event as defaults for queued,started,completed time #3532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…,completed time Default these values to the timestamps contained in the event. They will be updated if the log contains more accurate values, however the "Waiting for a runner to pick up this job..." and "Job is about to start running on the runner:" lines are only present in the logs until the job has finished, at which point they are removed from the job logs by Github, so they can't be used to calculate the job duration after the job has finished. Fixes actions#3522
jeremydonahue
requested review from
mumoshu,
toast-gear,
nikola-jokic,
rentziass and
a team
as code owners
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default these values to the timestamps contained in the event. They will be updated if the log contains more accurate values, however the "Waiting for a runner to pick up this job..." and "Job is about to start running on the runner:" lines are only present in the logs until the job has finished, at which point they are removed from the job logs by Github, so they can't be used to calculate the job duration after the job has finished.
Fixes #3522