Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cicero) Nested clause issue in markdown_cicero #323 #324

Merged
merged 1 commit into from
Sep 11, 2020
Merged

fix(cicero) Nested clause issue in markdown_cicero #323 #324

merged 1 commit into from
Sep 11, 2020
+118 −18

Conversation

jeromesimeon
Copy link
Member

Signed-off-by: Jerome Simeon jeromesimeon@me.com

Issue #323

Fixes issue with nested clauses in markdown + ciceromark extension.

Changes

  • Handles nested clauses, using a stack
  • Fixes issue with characters after opening clause tag

@jeromesimeon
fix(cicero) Nested clause issue in markdown_cicero accordproject#323
436aad4 
Signed-off-by: Jerome Simeon <jeromesimeon@me.com>
@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 89.205% when pulling 436aad4 on jeromesimeon:js-fix-nested-clause-323 into b6495e9 on accordproject:master.

@jeromesimeon jeromesimeon merged commit 9d2068c into accordproject:master Sep 11, 2020
@jeromesimeon jeromesimeon mentioned this pull request Sep 11, 2020
Closed
@jeromesimeon jeromesimeon deleted the js-fix-nested-clause-323 branch September 11, 2020 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeromesimeon @coveralls