Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been referring to this package as "NengoLMU", which is kind of confusing because it doesn't really use Nengo at all. So we're changing the name to KerasLMU, which reflects the fact that this is a Keras-based implementation of LMUs. We're also renaming the package itself to align with this name (so people will now
import keras_lmu
andpip install keras-lmu
). This is to clear the room for planned future implementations (e.g., anengo-lmu
which would actually be a Nengo-based LMU implementation). Although those packages don't exist yet, renaming the package itself at the same time as the "KerasLMU" name change seems appropriate.Note that I'll be setting up a separate
lmu
package, so people will still be able topip install lmu
, and if they do that thenimport lmu
will give them a deprecation message directing them tokeras-lmu
. In the future thatlmu
package will be used as a meta-package to install multiple LMU implementations.