Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of duplicate messages in case first transmission had an error. #8

Closed
chadgates opened this issue Jun 1, 2019 · 6 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@chadgates
Copy link
Contributor

When file is transferred and an error happens in processing, an MDN is triggered to the sender, stating that there was an error. Therefore the partner will resend the message.
However, when the partner resends, the new message is considered a "duplicate".

Shouldn't duplicate check check for successful messages only? Currently it seems it applies to all messages, irrespective of their status. Suggest to add the status to the filter criteria.

example of processing error, that seems to happen under some circumstances that I could not yet identify, usually around the time when a new folder was created, but it does not always happen on the first one:

An error occurred during the AS2 message processing: [Errno 17] File exists '/data/messages/__store/payload/received/20190530'
@abhishek-ram
Copy link
Owner

A duplicate message occurs only when there are issues in case of transmission. In other cases it should not happen and message should be resent with a new ID.

The issue you are talking about is a bug and should be considered as a valid scenario.

@abhishek-ram abhishek-ram self-assigned this Jun 4, 2019
@abhishek-ram abhishek-ram added the bug Something isn't working label Jun 4, 2019
@abhishek-ram
Copy link
Owner

abhishek-ram commented Jun 4, 2019

This issue has been fixed in later versions of django https://code.djangoproject.com/ticket/29890.

Should we just increase the django version in requirements @chadgates ?

@chadgates
Copy link
Contributor Author

@abhishek-ram: Yes, I would suggest 2.2 (being LTS).
I do have the problem on the previous version, still running on Python 2.7, so once I can migrate (currently the "binary"-issue is blocking my migration) I can monitor if that issue still happens.

@abhishek-ram
Copy link
Owner

Hmm so this issue was on the old pyas2?

@chadgates
Copy link
Contributor Author

Yes.

@abhishek-ram
Copy link
Owner

Handled in v1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants