{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":157159292,"defaultBranch":"main","name":"jyut-dict","ownerLogin":"aaronhktan","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2018-11-12T05:07:26.000Z","ownerAvatar":"https://github.com/avatars/u/14353716?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1712967501.0","currentOid":""},"activityList":{"items":[{"before":"effee4f30ee44d7fb4a3c609331eca838814b6f8","after":"4a1b48852cf57a567936b2bddc6f9dbd4c3252f3","ref":"refs/heads/main","pushedAt":"2024-04-17T01:52:51.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"aaronhktan","name":"Aaron Tan","path":"/aaronhktan","primaryAvatarUrl":"https://github.com/avatars/u/14353716?s=80&v=4"},"commit":{"message":"#178: Add ability to scroll through entry view using keyboard (#179)\n\n# Description\r\n\r\nThis commit adds ability to scroll through the entry view using the\r\nkeyboard arrow keys, page up/down, and the home/end keys.\r\n\r\nCloses #178.\r\n\r\n## Type of change\r\n\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n\r\n# How Has This Been Tested?\r\n\r\nInspected manually on macOS, Linux, and Windows.\r\n\r\n# Checklist:\r\n\r\n- [x] My code follows the style guidelines of this project (`black` for\r\nPython\r\n code, `.clang-format` in the `src/jyut-dict` directory for C++)\r\n- [x] I have performed a self-review of my own code\r\n- [x] I have commented my code, particularly in hard-to-understand areas\r\n- [x] I have translated my user-facing strings to all\r\ncurrently-supported languages\r\n- [x] I have made corresponding changes to the documentation","shortMessageHtmlLink":"#178: Add ability to scroll through entry view using keyboard (#179)"}},{"before":"706f99e8c08538b2bac5d9288620cdfe9a918c61","after":"effee4f30ee44d7fb4a3c609331eca838814b6f8","ref":"refs/heads/main","pushedAt":"2024-04-17T01:38:16.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"aaronhktan","name":"Aaron Tan","path":"/aaronhktan","primaryAvatarUrl":"https://github.com/avatars/u/14353716?s=80&v=4"},"commit":{"message":"#161: Improve some Cantonese UI translations (#180)\n\n# Description\r\n\r\nGot somebody to review some of the Canto translations and they suggested\r\nchanges. Also removed some simplified characters that somehow got into\r\nthe traditional Cantonese translation, and updated the README for\r\ncreating translation files.\r\n\r\n## Type of change\r\n\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n\r\n# How Has This Been Tested?\r\n\r\nTested on macOS 14.3.1 with Qt 5.15.12.\r\n\r\n# Checklist:\r\n\r\n- [x] My code follows the style guidelines of this project (`black` for\r\nPython\r\n code, `.clang-format` in the `src/jyut-dict` directory for C++)\r\n- [x] I have performed a self-review of my own code\r\n- [x] I have commented my code, particularly in hard-to-understand areas\r\n- [x] I have translated my user-facing strings to all\r\ncurrently-supported languages\r\n- [x] I have made corresponding changes to the documentation","shortMessageHtmlLink":"#161: Improve some Cantonese UI translations (#180)"}},{"before":"0add302cd8af9889e4cfeaed96a9fd32d1826717","after":"ff1276c0a8038d6aac2979127d6eb3faac2f84a7","ref":"refs/heads/bugfix/aaronhktan/fix-translations","pushedAt":"2024-04-13T00:20:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"aaronhktan","name":"Aaron Tan","path":"/aaronhktan","primaryAvatarUrl":"https://github.com/avatars/u/14353716?s=80&v=4"},"commit":{"message":"Update translation README with new instructions","shortMessageHtmlLink":"Update translation README with new instructions"}},{"before":null,"after":"0add302cd8af9889e4cfeaed96a9fd32d1826717","ref":"refs/heads/bugfix/aaronhktan/fix-translations","pushedAt":"2024-04-13T00:18:21.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"aaronhktan","name":"Aaron Tan","path":"/aaronhktan","primaryAvatarUrl":"https://github.com/avatars/u/14353716?s=80&v=4"},"commit":{"message":"Fix Cantonese translations\n\n- Made some translations sound a bit more idiomatic.\n- Removed some simplified Chinese that snuck into the traditional\n Cantonese translation.","shortMessageHtmlLink":"Fix Cantonese translations"}},{"before":null,"after":"2cac121a206d29437ff24ac42d9a3e9732a4fd5b","ref":"refs/heads/feature/aaronhktan/keyboard-navigation-entry-scroll-area","pushedAt":"2024-04-12T23:57:22.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"aaronhktan","name":"Aaron Tan","path":"/aaronhktan","primaryAvatarUrl":"https://github.com/avatars/u/14353716?s=80&v=4"},"commit":{"message":"Add ability to scroll through entry view using keyboard\n\n- Not sure why this wasn't working before, and why setting the focus\n policy also doesn't fix it. Anyway, adding this key handler should be\n a good-enough workaround for now.","shortMessageHtmlLink":"Add ability to scroll through entry view using keyboard"}},{"before":"822e709f38c482d118bbe649ed0af4639b37caf9","after":"706f99e8c08538b2bac5d9288620cdfe9a918c61","ref":"refs/heads/main","pushedAt":"2024-03-30T06:53:42.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"aaronhktan","name":"Aaron Tan","path":"/aaronhktan","primaryAvatarUrl":"https://github.com/avatars/u/14353716?s=80&v=4"},"commit":{"message":"#161: Update build instructions in README (#176)\n\n# Description\r\n\r\nOne of the dependencies for the Craft build on Windows/Mac was\r\nincorrectly specified (should be `libs/qt/qtmultimedia` instead of\r\n`libs/qt/multimedia`).\r\n\r\n## Type of change\r\n\r\n- [x] This change requires a documentation update\r\n\r\n# How Has This Been Tested?\r\nN/A\r\n\r\n# Checklist:\r\n\r\n- [x] I have made corresponding changes to the documentation","shortMessageHtmlLink":"#161: Update build instructions in README (#176)"}},{"before":"5295cdbb1b9276743cab8eb920ae489c6b65eb78","after":"822e709f38c482d118bbe649ed0af4639b37caf9","ref":"refs/heads/main","pushedAt":"2024-03-30T06:53:30.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"aaronhktan","name":"Aaron Tan","path":"/aaronhktan","primaryAvatarUrl":"https://github.com/avatars/u/14353716?s=80&v=4"},"commit":{"message":"#160: Unit-test SQLUserHistoryUtils (#177)\n\n# Description\r\n\r\nThis commit adds unit tests to SQLUserHistoryUtils.\r\n\r\nFinishes off the series of commits that adds unit tests, and thus closes #160.\r\n\r\n## Type of change\r\n\r\n- [x] New feature (non-breaking change which adds functionality)\r\n\r\n# How Has This Been Tested?\r\n\r\nTested on Fedora 39.\r\n\r\n# Checklist:\r\n\r\n- [x] My code follows the style guidelines of this project (`black` for\r\nPython\r\n code, `.clang-format` in the `src/jyut-dict` directory for C++)\r\n- [x] I have performed a self-review of my own code\r\n- [x] I have commented my code, particularly in hard-to-understand areas\r\n- [x] I have translated my user-facing strings to all\r\ncurrently-supported languages\r\n- [x] I have made corresponding changes to the documentation","shortMessageHtmlLink":"#160: Unit-test SQLUserHistoryUtils (#177)"}},{"before":"e7b330f42aae2695de64f2f4466a1dca5173e707","after":"8afcb874ccbc1653e03b4f8dde5129ea79797c15","ref":"refs/heads/maintenance/aaronhktan/unit-test-sqluserhistoryutils","pushedAt":"2024-03-30T06:50:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"aaronhktan","name":"Aaron Tan","path":"/aaronhktan","primaryAvatarUrl":"https://github.com/avatars/u/14353716?s=80&v=4"},"commit":{"message":"Remove CMakeLists.txt.user file","shortMessageHtmlLink":"Remove CMakeLists.txt.user file"}},{"before":null,"after":"e7b330f42aae2695de64f2f4466a1dca5173e707","ref":"refs/heads/maintenance/aaronhktan/unit-test-sqluserhistoryutils","pushedAt":"2024-03-30T06:39:44.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"aaronhktan","name":"Aaron Tan","path":"/aaronhktan","primaryAvatarUrl":"https://github.com/avatars/u/14353716?s=80&v=4"},"commit":{"message":"Add unit tests for SQLUserHistoryUtils","shortMessageHtmlLink":"Add unit tests for SQLUserHistoryUtils"}},{"before":null,"after":"96d64cf764465a5c92023a889bbf0899cd4ba69f","ref":"refs/heads/maintenance/aaronhktan/update-craft-readme","pushedAt":"2024-03-30T04:41:20.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"aaronhktan","name":"Aaron Tan","path":"/aaronhktan","primaryAvatarUrl":"https://github.com/avatars/u/14353716?s=80&v=4"},"commit":{"message":"Update build instructions in README","shortMessageHtmlLink":"Update build instructions in README"}},{"before":"3bdfcbe65300a2f31d555f6792ff2b159f0e7813","after":"5295cdbb1b9276743cab8eb920ae489c6b65eb78","ref":"refs/heads/main","pushedAt":"2024-03-27T05:35:45.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"aaronhktan","name":"Aaron Tan","path":"/aaronhktan","primaryAvatarUrl":"https://github.com/avatars/u/14353716?s=80&v=4"},"commit":{"message":"#160: Unit test SQLUserDataUtils (#175)\n\n# Description\r\n\r\nThis commit adds unit tests for SQLUserDataUtils.\r\n\r\nPart of a series of commits for #160.\r\n\r\n## Type of change\r\n\r\n- [x] New feature (non-breaking change which adds functionality)\r\n\r\n# How Has This Been Tested?\r\n\r\nTested on all three platforms.\r\n\r\n# Checklist:\r\n\r\n- [x] My code follows the style guidelines of this project (`black` for\r\nPython\r\n code, `.clang-format` in the `src/jyut-dict` directory for C++)\r\n- [x] I have performed a self-review of my own code\r\n- [x] I have commented my code, particularly in hard-to-understand areas\r\n- [x] I have translated my user-facing strings to all\r\ncurrently-supported languages\r\n- [x] I have made corresponding changes to the documentation","shortMessageHtmlLink":"#160: Unit test SQLUserDataUtils (#175)"}},{"before":"641de5c948642f6dcd7b27df15d4de820b88b15c","after":"4a193dc3badc783d6ffaa028c5c7fa5ce1212653","ref":"refs/heads/maintenance/aaronhktan/unit-test-sqluserdatautils","pushedAt":"2024-03-26T07:40:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"aaronhktan","name":"Aaron Tan","path":"/aaronhktan","primaryAvatarUrl":"https://github.com/avatars/u/14353716?s=80&v=4"},"commit":{"message":"Uncomment lines in destructor","shortMessageHtmlLink":"Uncomment lines in destructor"}},{"before":"0ef584c52251a8f0349529744947687c1b38e862","after":"641de5c948642f6dcd7b27df15d4de820b88b15c","ref":"refs/heads/maintenance/aaronhktan/unit-test-sqluserdatautils","pushedAt":"2024-03-26T07:34:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"aaronhktan","name":"Aaron Tan","path":"/aaronhktan","primaryAvatarUrl":"https://github.com/avatars/u/14353716?s=80&v=4"},"commit":{"message":"Add test subdirectory to CMakeLists.txt","shortMessageHtmlLink":"Add test subdirectory to CMakeLists.txt"}},{"before":null,"after":"0ef584c52251a8f0349529744947687c1b38e862","ref":"refs/heads/maintenance/aaronhktan/unit-test-sqluserdatautils","pushedAt":"2024-03-26T07:10:38.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"aaronhktan","name":"Aaron Tan","path":"/aaronhktan","primaryAvatarUrl":"https://github.com/avatars/u/14353716?s=80&v=4"},"commit":{"message":"Add unit tests for SQLUserDataUtils","shortMessageHtmlLink":"Add unit tests for SQLUserDataUtils"}},{"before":"76a229a44070dd5f4b9c05300382a61e86cef158","after":"3bdfcbe65300a2f31d555f6792ff2b159f0e7813","ref":"refs/heads/main","pushedAt":"2024-03-15T04:52:51.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"aaronhktan","name":"Aaron Tan","path":"/aaronhktan","primaryAvatarUrl":"https://github.com/avatars/u/14353716?s=80&v=4"},"commit":{"message":"#160: Write unit tests for SQLSearch (#174)\n\n# Description\r\n\r\n- This commit adds tests for the SQLSearch class.\r\n- This commit fixes some logic in SegmentPinyin/SegmentJyutping\r\ninvolving\r\n glob characters, where invalid sequences before glob characters would\r\n not be added to the search term.\r\n- This commit fixes the parsing of the 'direct' field in sentence\r\n links. Since SQLite stores booleans as integers, QJsonValue::toBool()\r\n would always return \"false\", even if the stored value was 1.\r\n- This commit adds comparison of definitions and sentences when\r\n checking for equality in the Entry class.\r\n- This commit adds additional data members to operator<< in Entry et al.\r\n- This commit adds the ability to remove all database connections, which\r\nis useful on Windows since we cannot delete a database file that\r\nsomebody\r\n is keeping a connection open to.\r\n\r\nPart of a series of commits for #160.\r\n\r\n## Type of change\r\n\r\n- [x] New feature (non-breaking change which adds functionality)\r\n\r\n# How Has This Been Tested?\r\n\r\nTested on all three platforms.\r\n\r\n```\r\nPASS\tExecuting test case TestSqlSearch\r\n\tQt version: 5.15.12\r\n\tQt build: Qt 5.15.12 (arm64-little_endian-lp64 shared (dynamic) release build; by Clang 15.0.0 (clang-1500.0.40.1) (Apple))\r\n\tQTest version: 5.15.12\r\nPASS\tExecuting test function initTestCase\r\nPASS\tTestSqlSearch::initTestCase\r\n\tExecution took 0.038041 ms.\r\nPASS\tExecuting test function searchSimplified\r\nPASS\tTestSqlSearch::searchSimplified\r\n\tExecution took 3.75446 ms.\r\nPASS\tExecuting test function searchSimplifiedNoResults\r\nPASS\tTestSqlSearch::searchSimplifiedNoResults\r\n\tExecution took 1.11429 ms.\r\nPASS\tExecuting test function searchTraditional\r\nPASS\tTestSqlSearch::searchTraditional\r\n\tExecution took 2.98029 ms.\r\nPASS\tExecuting test function searchTraditionalNoResults\r\nPASS\tTestSqlSearch::searchTraditionalNoResults\r\n\tExecution took 0.9655 ms.\r\nPASS\tExecuting test function searchJyutping\r\nPASS\tTestSqlSearch::searchJyutping\r\n\tExecution took 5.23442 ms.\r\nPASS\tExecuting test function searchJyutpingNoResults\r\nPASS\tTestSqlSearch::searchJyutpingNoResults\r\n\tExecution took 1.93096 ms.\r\nPASS\tExecuting test function searchPinyin\r\nPASS\tTestSqlSearch::searchPinyin\r\n\tExecution took 5.00858 ms.\r\nPASS\tExecuting test function searchPinyinNoResults\r\nPASS\tTestSqlSearch::searchPinyinNoResults\r\n\tExecution took 1.70817 ms.\r\nPASS\tExecuting test function searchEnglish\r\nPASS\tTestSqlSearch::searchEnglish\r\n\tExecution took 3.71446 ms.\r\nPASS\tExecuting test function searchEnglishNoResults\r\nPASS\tTestSqlSearch::searchEnglishNoResults\r\n\tExecution took 0.59975 ms.\r\nPASS\tExecuting test function searchAutoDetect\r\nPASS\tTestSqlSearch::searchAutoDetect\r\n\tExecution took 19.7345 ms.\r\nPASS\tExecuting test function searchAutoDetectNoResults\r\nPASS\tTestSqlSearch::searchAutoDetectNoResults\r\n\tExecution took 2.96712 ms.\r\nPASS\tExecuting test function searchUnique\r\nPASS\tTestSqlSearch::searchUnique\r\n\tExecution took 0.923375 ms.\r\nPASS\tExecuting test function searchTraditionalSentences\r\nPASS\tTestSqlSearch::searchTraditionalSentences\r\n\tExecution took 0.373875 ms.\r\nPASS\tExecuting test function cleanupTestCase\r\nPASS\tTestSqlSearch::cleanupTestCase\r\n\tExecution took 0.001458 ms.\r\n\tTest execution took 51.1339 ms.\r\n```\r\n\r\n# Checklist:\r\n\r\n- [x] My code follows the style guidelines of this project (`black` for\r\nPython\r\n code, `.clang-format` in the `src/jyut-dict` directory for C++)\r\n- [x] I have performed a self-review of my own code\r\n- [x] I have commented my code, particularly in hard-to-understand areas\r\n- [x] I have translated my user-facing strings to all\r\ncurrently-supported languages\r\n- [x] I have made corresponding changes to the documentation","shortMessageHtmlLink":"#160: Write unit tests for SQLSearch (#174)"}},{"before":"fd1d850fc684767d4f3ad6b138b27a8ee5a27a8a","after":"76a229a44070dd5f4b9c05300382a61e86cef158","ref":"refs/heads/main","pushedAt":"2024-03-15T04:52:29.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"aaronhktan","name":"Aaron Tan","path":"/aaronhktan","primaryAvatarUrl":"https://github.com/avatars/u/14353716?s=80&v=4"},"commit":{"message":"#161: Remove static variable declaration in header file (#173)\n\n# Description\r\n\r\n- The map name_to_short_name was declared static in a header file\r\nbefore. This meant that every translation unit would have its own copy\r\nof the vector. Not sure why it ever worked before, since the vector was\r\nonly populated in main.cpp...\r\n- Also added synchronization primitives for the unordered_map.\r\n\r\nPart of commits for #161.\r\n\r\n## Type of change\r\n\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n\r\n# How Has This Been Tested?\r\n\r\nBuilt and run on all three platforms. All unit tests passed.\r\n\r\n# Checklist:\r\n\r\n- [x] My code follows the style guidelines of this project (`black` for\r\nPython\r\n code, `.clang-format` in the `src/jyut-dict` directory for C++)\r\n- [x] I have performed a self-review of my own code\r\n- [x] I have commented my code, particularly in hard-to-understand areas\r\n- [x] I have translated my user-facing strings to all\r\ncurrently-supported languages\r\n- [x] I have made corresponding changes to the documentation","shortMessageHtmlLink":"#161: Remove static variable declaration in header file (#173)"}},{"before":"58fd3bf0c827d470a2fdd0b819f9ccf2958ce9ac","after":"92e2d2e680d41a4420a7e09b529c549eee4a6252","ref":"refs/heads/maintenance/aaronhktan/unit-test-sqlsearch","pushedAt":"2024-03-14T08:28:53.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"aaronhktan","name":"Aaron Tan","path":"/aaronhktan","primaryAvatarUrl":"https://github.com/avatars/u/14353716?s=80&v=4"},"commit":{"message":"Add test for SQLDatabaesManager::removeAllDatabaseConnections()","shortMessageHtmlLink":"Add test for SQLDatabaesManager::removeAllDatabaseConnections()"}},{"before":"f9f5205e5a528478a06921f134f484facfae897e","after":"58fd3bf0c827d470a2fdd0b819f9ccf2958ce9ac","ref":"refs/heads/maintenance/aaronhktan/unit-test-sqlsearch","pushedAt":"2024-03-14T08:09:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"aaronhktan","name":"Aaron Tan","path":"/aaronhktan","primaryAvatarUrl":"https://github.com/avatars/u/14353716?s=80&v=4"},"commit":{"message":"Add ability to remove all database connections\n\n- On Windows, files can't be deleted if there is anything that\n has them open. By removing all the connections to the database,\n it can be deleted.","shortMessageHtmlLink":"Add ability to remove all database connections"}},{"before":"6664a863e09f48997912fc2713e7e00aa768f06f","after":"f9f5205e5a528478a06921f134f484facfae897e","ref":"refs/heads/maintenance/aaronhktan/unit-test-sqlsearch","pushedAt":"2024-03-14T07:03:51.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aaronhktan","name":"Aaron Tan","path":"/aaronhktan","primaryAvatarUrl":"https://github.com/avatars/u/14353716?s=80&v=4"},"commit":{"message":"Write unit tests for SQLSearch\n\n- This commit adds tests for the SQLSearch class.\n- This commit fixes some logic in SegmentPinyin/SegmentJyutping involving\n glob characters, where invalid sequences before glob characters would\n not be added to the search term.\n- This commit fixes the parsing of the 'direct' field in sentence\n links. Since SQLite stores booleans as integers, QJsonValue::toBool()\n would always return \"false\", even if the stored value was 1.\n- This commit adds comparison of definitions and sentences when\n checking for equality in the Entry class.\n- This commit adds additional data members to operator<< in Entry et al.","shortMessageHtmlLink":"Write unit tests for SQLSearch"}},{"before":null,"after":"6664a863e09f48997912fc2713e7e00aa768f06f","ref":"refs/heads/maintenance/aaronhktan/unit-test-sqlsearch","pushedAt":"2024-03-14T06:35:56.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"aaronhktan","name":"Aaron Tan","path":"/aaronhktan","primaryAvatarUrl":"https://github.com/avatars/u/14353716?s=80&v=4"},"commit":{"message":"Write unit tests for SQLSearch\n\n- This commit adds tests for the SQLSearch class.\n- This commit fixes some logic in SegmentPinyin/SegmentJyutping involving\n glob characters, where invalid sequences before glob characters would\n not be added to the search term.\n- This commit fixes the parsing of the 'direct' field in sentence\n links. Since SQLite stores booleans as integers, QJsonValue::toBool()\n would always return \"false\", even if the stored value was 1.\n- This commit adds comparison of definitions and sentences when\n checking for equality in the Entry class.\n- This commit adds additional data members to operator<< in Entry et al.","shortMessageHtmlLink":"Write unit tests for SQLSearch"}},{"before":null,"after":"c92ba0cf4fbdf1c286883d9f881f064441ed49ce","ref":"refs/heads/bugfix/aaronhktan/remove-static-declaration-in-header","pushedAt":"2024-03-14T02:29:42.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"aaronhktan","name":"Aaron Tan","path":"/aaronhktan","primaryAvatarUrl":"https://github.com/avatars/u/14353716?s=80&v=4"},"commit":{"message":"Remove static variable declaration in header file\n\n- The map name_to_short_name was declared static in a header file\n before. This meant that every translation unit would have its own\n copy of the vector. Not sure why it ever worked before, since the\n vector was only populated in main.cpp...\n- Also added synchronization primitives for the unordered_map.","shortMessageHtmlLink":"Remove static variable declaration in header file"}},{"before":"b5b357b0a4bbb6f012c9c9b4017b98fbb5c81f2f","after":"fd1d850fc684767d4f3ad6b138b27a8ee5a27a8a","ref":"refs/heads/main","pushedAt":"2024-03-14T02:15:30.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"aaronhktan","name":"Aaron Tan","path":"/aaronhktan","primaryAvatarUrl":"https://github.com/avatars/u/14353716?s=80&v=4"},"commit":{"message":"#160: Write unit tests for SQLDatabaseUtils (#172)\n\n# Description\r\n\r\nThis commit adds unit tests that test version upgrade functionality, as\r\nwell as dictionary import functionality.\r\n\r\nPart of a series of commits for #160.\r\n\r\n## Type of change\r\n\r\n- [x] New feature (non-breaking change which adds functionality)\r\n\r\n# How Has This Been Tested?\r\n\r\nTested on all three platforms.\r\n\r\n```\r\nPASS\tExecuting test case TestSqlDatabaseUtils\r\n\tQt version: 5.15.2\r\n\tQt build: Qt 5.15.2 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 5.3.1 20160406 (Red Hat 5.3.1-6))\r\n\tQTest version: 5.15.2\r\nPASS\tExecuting test function initTestCase\r\nPASS\tTestSqlDatabaseUtils::initTestCase\r\n\tExecution took 0.259449 ms.\r\nPASS\tExecuting test function updateDatabaseFromV1\r\nPASS\tTestSqlDatabaseUtils::updateDatabaseFromV1\r\n\tExecution took 49.8147 ms.\r\nPASS\tExecuting test function updateDatabaseFromV2\r\nPASS\tTestSqlDatabaseUtils::updateDatabaseFromV2\r\n\tExecution took 44.7733 ms.\r\nPASS\tExecuting test function addAndRemoveSources\r\nPASS\tTestSqlDatabaseUtils::addAndRemoveSources\r\n\tExecution took 53.7935 ms.\r\nPASS\tExecuting test function readSources\r\nPASS\tTestSqlDatabaseUtils::readSources\r\n\tExecution took 33.3397 ms.\r\nPASS\tExecuting test function cleanupTestCase\r\nPASS\tTestSqlDatabaseUtils::cleanupTestCase\r\n\tExecution took 0.001573 ms.\r\n\tTest execution took 182.273 ms.\r\n```\r\n\r\n# Checklist:\r\n\r\n- [x] My code follows the style guidelines of this project (`black` for\r\nPython\r\n code, `.clang-format` in the `src/jyut-dict` directory for C++)\r\n- [x] I have performed a self-review of my own code\r\n- [x] I have commented my code, particularly in hard-to-understand areas\r\n- [x] I have translated my user-facing strings to all\r\ncurrently-supported languages\r\n- [x] I have made corresponding changes to the documentation","shortMessageHtmlLink":"#160: Write unit tests for SQLDatabaseUtils (#172)"}},{"before":null,"after":"55d90bdff13a749c17682741d2f2bc19e578dc8c","ref":"refs/heads/maintenance/aaronhktan/unit-test-sqldatabaseutils","pushedAt":"2024-03-13T06:00:57.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"aaronhktan","name":"Aaron Tan","path":"/aaronhktan","primaryAvatarUrl":"https://github.com/avatars/u/14353716?s=80&v=4"},"commit":{"message":"Write unit tests for SQLDatabaseUtils\n\n- These unit tests test the version upgrade functionality, as well\n as dictionary import functionality.","shortMessageHtmlLink":"Write unit tests for SQLDatabaseUtils"}},{"before":"329790ceabcdf5bc9d445553163ead419ccecabb","after":"b5b357b0a4bbb6f012c9c9b4017b98fbb5c81f2f","ref":"refs/heads/main","pushedAt":"2024-03-13T02:15:20.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"aaronhktan","name":"Aaron Tan","path":"/aaronhktan","primaryAvatarUrl":"https://github.com/avatars/u/14353716?s=80&v=4"},"commit":{"message":"#160: Add unit tests for SQLDatabaseManager (#171)\n\n# Description\r\n\r\nThis commit adds two unit tests for SQLDatabaseManager, opening/closing\r\nthe database and backing up/restoring the database.\r\n\r\nPart of a series of commits for #160.\r\n\r\n## Type of change\r\n\r\n- [x] New feature (non-breaking change which adds functionality)\r\n\r\n# How Has This Been Tested?\r\n\r\nTested on all three platforms, macOS, Windows, and Linux.\r\n\r\n```\r\nPASS\tExecuting test case TestSqlDatabaseManager\r\n\tQt version: 5.15.2\r\n\tQt build: Qt 5.15.2 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 5.3.1 20160406 (Red Hat 5.3.1-6))\r\n\tQTest version: 5.15.2\r\nPASS\tExecuting test function initTestCase\r\nPASS\tTestSqlDatabaseManager::initTestCase\r\n\tExecution took 0.225096 ms.\r\nPASS\tExecuting test function getDatabase\r\nPASS\tTestSqlDatabaseManager::getDatabase\r\n\tExecution took 6.00906 ms.\r\nPASS\tExecuting test function backupAndRestore\r\nPASS\tTestSqlDatabaseManager::backupAndRestore\r\n\tExecution took 0.592482 ms.\r\nPASS\tExecuting test function cleanupTestCase\r\nPASS\tTestSqlDatabaseManager::cleanupTestCase\r\n\tExecution took 0.002374 ms.\r\n\tTest execution took 7.23439 ms.\r\n```\r\n\r\n# Checklist:\r\n\r\n- [x] My code follows the style guidelines of this project (`black` for\r\nPython\r\n code, `.clang-format` in the `src/jyut-dict` directory for C++)\r\n- [x] I have performed a self-review of my own code\r\n- [x] I have commented my code, particularly in hard-to-understand areas\r\n- [x] I have translated my user-facing strings to all\r\ncurrently-supported languages\r\n- [x] I have made corresponding changes to the documentation","shortMessageHtmlLink":"#160: Add unit tests for SQLDatabaseManager (#171)"}},{"before":"31b6f22a9cdf7947cd262d8405b1151021ef0876","after":"e3939754f9c06038ef0f22aa17765928ca4c73ad","ref":"refs/heads/maintenance/aaronhktan/unit-test-sqldatabasemanager","pushedAt":"2024-03-12T06:07:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"aaronhktan","name":"Aaron Tan","path":"/aaronhktan","primaryAvatarUrl":"https://github.com/avatars/u/14353716?s=80&v=4"},"commit":{"message":"Remove unnecessary calls","shortMessageHtmlLink":"Remove unnecessary calls"}},{"before":"6e11d1262501ac4bdf864cf1db6244896b7bf7b3","after":"31b6f22a9cdf7947cd262d8405b1151021ef0876","ref":"refs/heads/maintenance/aaronhktan/unit-test-sqldatabasemanager","pushedAt":"2024-03-12T05:59:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"aaronhktan","name":"Aaron Tan","path":"/aaronhktan","primaryAvatarUrl":"https://github.com/avatars/u/14353716?s=80&v=4"},"commit":{"message":"Fix up test on Windows","shortMessageHtmlLink":"Fix up test on Windows"}},{"before":null,"after":"6e11d1262501ac4bdf864cf1db6244896b7bf7b3","ref":"refs/heads/maintenance/aaronhktan/unit-test-sqldatabasemanager","pushedAt":"2024-03-12T05:36:10.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"aaronhktan","name":"Aaron Tan","path":"/aaronhktan","primaryAvatarUrl":"https://github.com/avatars/u/14353716?s=80&v=4"},"commit":{"message":"Write unit tests for SQLDatabaseManager","shortMessageHtmlLink":"Write unit tests for SQLDatabaseManager"}},{"before":"3ba39fe26f5b3e493c93452df2effa8716c99a39","after":"329790ceabcdf5bc9d445553163ead419ccecabb","ref":"refs/heads/main","pushedAt":"2024-03-11T07:15:02.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"aaronhktan","name":"Aaron Tan","path":"/aaronhktan","primaryAvatarUrl":"https://github.com/avatars/u/14353716?s=80&v=4"},"commit":{"message":"#160: Write unit tests for DefinitionsSet (#170)\n\n# Description\r\n\r\nThis commit adds unit tests for the DefinitionsSet class.\r\n\r\nPart of a series of commits for #160.\r\n\r\n## Type of change\r\n\r\n- [x] New feature (non-breaking change which adds functionality)\r\n\r\n# How Has This Been Tested?\r\n\r\nTested on macOS, Windows, and Linux.\r\n\r\n```\r\nPASS\tExecuting test case TestDefinitionsSet\r\n\tQt version: 5.15.12\r\n\tQt build: Qt 5.15.12 (x86_64-little_endian-llp64 shared (dynamic) release build; by GCC 11.2.0)\r\n\tQTest version: 5.15.12\r\nPASS\tExecuting test function initTestCase\r\nPASS\tTestDefinitionsSet::initTestCase\r\n\tExecution took 0.1693 ms.\r\nPASS\tExecuting test function isEmpty\r\nPASS\tTestDefinitionsSet::isEmpty\r\n\tExecution took 0.0156 ms.\r\nPASS\tExecuting test function addDefinitions\r\nPASS\tTestDefinitionsSet::addDefinitions\r\n\tExecution took 0.0217 ms.\r\nPASS\tExecuting test function getSources\r\nPASS\tTestDefinitionsSet::getSources\r\n\tExecution took 0.0795 ms.\r\nPASS\tExecuting test function getDefinitions\r\nPASS\tTestDefinitionsSet::getDefinitions\r\n\tExecution took 0.0499 ms.\r\nPASS\tExecuting test function cleanupTestCase\r\nPASS\tTestDefinitionsSet::cleanupTestCase\r\n\tExecution took 0.004 ms.\r\n\tTest execution took 0.5707 ms.\r\n```\r\n\r\n# Checklist:\r\n\r\n- [x] My code follows the style guidelines of this project (`black` for\r\nPython\r\n code, `.clang-format` in the `src/jyut-dict` directory for C++)\r\n- [x] I have performed a self-review of my own code\r\n- [x] I have commented my code, particularly in hard-to-understand areas\r\n- [x] I have translated my user-facing strings to all\r\ncurrently-supported languages\r\n- [x] I have made corresponding changes to the documentation","shortMessageHtmlLink":"#160: Write unit tests for DefinitionsSet (#170)"}},{"before":"5c4de4256710f6fe4605624670a12c91dbb25e9e","after":"eb047468b6feb2ee537297806faaced12b26ad83","ref":"refs/heads/maintenance/aaronhktan/unit-test-definitionsset","pushedAt":"2024-03-11T06:52:08.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aaronhktan","name":"Aaron Tan","path":"/aaronhktan","primaryAvatarUrl":"https://github.com/avatars/u/14353716?s=80&v=4"},"commit":{"message":"Write unit tests for DefinitionsSet","shortMessageHtmlLink":"Write unit tests for DefinitionsSet"}},{"before":"614fd17147ccb650472979ea8237edacb2d17f20","after":"3ba39fe26f5b3e493c93452df2effa8716c99a39","ref":"refs/heads/main","pushedAt":"2024-03-11T06:30:27.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"aaronhktan","name":"Aaron Tan","path":"/aaronhktan","primaryAvatarUrl":"https://github.com/avatars/u/14353716?s=80&v=4"},"commit":{"message":"#160: Unit-test Entry class (#169)\n\n# Description\r\n\r\nThis commit adds unit tests for the Entry class, which represents an\r\nentry in the dictionary. In order to do that, it also adds `==` operator\r\noverloads to several of the classes it depends on (SourceSentence,\r\nDefinitionsSet, etc).\r\n\r\nPart of a series of commits for #160.\r\n\r\n## Type of change\r\n\r\n- [x] New feature (non-breaking change which adds functionality)\r\n\r\n# How Has This Been Tested?\r\n\r\nTested on macOS, Windows, and Linux.\r\n\r\n# Checklist:\r\n\r\n- [x] My code follows the style guidelines of this project (`black` for\r\nPython\r\n code, `.clang-format` in the `src/jyut-dict` directory for C++)\r\n- [x] I have performed a self-review of my own code\r\n- [x] I have commented my code, particularly in hard-to-understand areas\r\n- [x] I have translated my user-facing strings to all\r\ncurrently-supported languages\r\n- [x] I have made corresponding changes to the documentation","shortMessageHtmlLink":"#160: Unit-test Entry class (#169)"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEMpbz4wA","startCursor":null,"endCursor":null}},"title":"Activity ยท aaronhktan/jyut-dict"}