-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversion fails if label has language and choice_filter is used #355
Comments
@KeynesYouDigIt I think your PR is the cause of this regression. Can you see if you can reproduce and fix? |
I think we should revert #287. I have a narrow fix for this crash at master...lognaturel:pyxform-355 but the more I dig into the behavior of #287, the more I think it will be confusing to users. For example, see test
I think this is an extremely confusing message. I think we should start by designing the desired user experience for #157 before building it. The error messages and the cases in which they're displayed should be clear. The tests should verify that the expected messages are displayed, not just the count of error messages. |
Sorry missed this thread somehow, looking at a patch now |
I re added my changes but can't reproduce this issue, the test form converts fine. Is there something specific I did differenly in the form I cnverted? Or were you running a command other than
Heres the form I ran this on
|
Python2 just throws a seperate error
|
Having trouble reproducing this error, here is the test I am using I am going to go forward with a 'safer' fix and PR soon |
This is a regression with v0.15.0 and I suspect the problem is #287.
Here's the form in question.
test.xlsx
Fails
If I have a question with the proper label and a choice_filter, it fails.
Works
If I have I change to choice-filter
choice-filter
orlabel::English (en)
, then it works.The text was updated successfully, but these errors were encountered: