-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
start-geopoint fails ODK Validate validation because of stub setgeopoint implementation #351
Comments
A little retrospection:
I think we need to make sure to actually try a sample form and/or make sure to run the tests with Validate on. The reason for the issue:
I've gone back and forth on where to fix this. I'm going to do a Validate change for now and we can always adjust if needed. |
I'm trying to think of a more systemic way for us to catch this class of problem. @ukanga would it be crazy to change all (most?) pyxforms tests to run through Validate. |
I think it would take too long to run and not be valuable in most cases. As reviewers, I think we need to remember check when a Validate check should be required. How about adding it to the PR template so that both the submitter and the reviewer get a reminder? |
#341 adds support for
start-geopoint
. The XForms output that is generated is what is described in the spec and works in e.g. Collect. However, it fails Validate because JavaRosa's stub implementation of thesetgeopoint
action provides a string that then is attempted to cast to a geopoint.I'm not sure whether to address this at the JavaRosa or Validate level. Either way, I think we'd need to supply a bogus value in geopoint format rather than an arbitrary string. Filing this here so we know there's still work to do on that front.
CC @yanokwa
The text was updated successfully, but these errors were encountered: