Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External choices with integers in names/values are converted to decimals #123

Closed
yanokwa opened this issue Jun 8, 2017 · 5 comments
Closed

External choices with integers in names/values are converted to decimals #123

yanokwa opened this issue Jun 8, 2017 · 5 comments

Comments

@yanokwa
Copy link
Contributor

yanokwa commented Jun 8, 2017

If you have an external choice with the name/value of "1", pyxform converts this value to "1.0" in the itemsets.csv. This does not happen with regular choices.

Input

Output
@phil-wilson
Copy link

@MartijnR Note this breaks cascading selects and/or using pulldata() functions, as the integer being converted to decimal does not match the original value in choices sheet or other csv source.

@MartijnR
Copy link
Contributor

Definitely a bug and a serious one.

@yanokwa
Copy link
Contributor Author

yanokwa commented Jan 10, 2018

@phil-wilson @MartijnR Either of you able to send in a PR?

@MartijnR
Copy link
Contributor

No, sorry, I cannot unfortunately.

@phil-wilson
Copy link

@spatialdude

@WinnyTroy WinnyTroy mentioned this issue May 10, 2019
Merged
@ukanga ukanga closed this as completed Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@yanokwa @ukanga @MartijnR @phil-wilson