From 55aa76aa25e9f0f31a54f7bbe3e840b24427d314 Mon Sep 17 00:00:00 2001 From: Tonya Mork Date: Wed, 18 Sep 2024 18:44:15 +0000 Subject: [PATCH] Code Modernization: Explicitly declare all properties in AtomParser. Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2 and are expected to become a fatal error in PHP 9.0. There are a number of ways to mitigate this: * If it's an accidental typo for a declared property: fix the typo. * For known properties: declare them on the class. * For unknown properties: add the magic `__get()`, `__set()` et al methods to the class or let the class extend `stdClass` which has highly optimized versions of these magic methods build in. * For unknown _use of_ dynamic properties, the `#[AllowDynamicProperties]` attribute can be added to the class. The attribute will automatically be inherited by child classes. In this case, the property added are explicitly referenced in this class, so fall in the "known property" category. Refs: * https://wiki.php.net/rfc/deprecate_dynamic_properties Props jrf. See #56034. git-svn-id: https://develop.svn.wordpress.org/trunk@59058 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-includes/atomlib.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/wp-includes/atomlib.php b/src/wp-includes/atomlib.php index 90f6282243cfe..91407cb98709e 100644 --- a/src/wp-includes/atomlib.php +++ b/src/wp-includes/atomlib.php @@ -86,6 +86,10 @@ class AtomParser { var $feed; var $current; + var $map_attrs_func; + var $map_xmlns_func; + var $error; + var $content; /** * PHP5 constructor.