From 76369b4281b899c78c4c0b3caa04a22ae2adf9d2 Mon Sep 17 00:00:00 2001 From: Weston Ruter Date: Mon, 29 Jul 2024 17:39:48 -0700 Subject: [PATCH] Use 500px as a better representation of an element that could be LCP --- .../embed-optimizer/tests/test-cases/nested-figure-embed.php | 4 ++-- ...-spotify-embed-outside-viewport-with-subsequent-script.php | 2 +- .../tests/test-cases/single-twitter-embed-inside-viewport.php | 2 +- .../test-cases/single-twitter-embed-outside-viewport.php | 2 +- .../test-cases/single-wordpress-tv-embed-inside-viewport.php | 2 +- .../test-cases/single-wordpress-tv-embed-outside-viewport.php | 2 +- .../tests/test-cases/single-youtube-embed-inside-viewport.php | 2 +- .../test-cases/single-youtube-embed-outside-viewport.php | 2 +- tests/class-optimization-detective-test-helpers.php | 4 ++-- 9 files changed, 11 insertions(+), 11 deletions(-) diff --git a/plugins/embed-optimizer/tests/test-cases/nested-figure-embed.php b/plugins/embed-optimizer/tests/test-cases/nested-figure-embed.php index 30bd54a190..685a496e91 100644 --- a/plugins/embed-optimizer/tests/test-cases/nested-figure-embed.php +++ b/plugins/embed-optimizer/tests/test-cases/nested-figure-embed.php @@ -101,12 +101,12 @@ static function ( OD_Tag_Visitor_Context $context ) use ( $test_case ): bool { -
+
-
+

So I heard you like FIGURE?

diff --git a/plugins/embed-optimizer/tests/test-cases/single-spotify-embed-outside-viewport-with-subsequent-script.php b/plugins/embed-optimizer/tests/test-cases/single-spotify-embed-outside-viewport-with-subsequent-script.php index b25fb71c53..523f85e6e7 100644 --- a/plugins/embed-optimizer/tests/test-cases/single-spotify-embed-outside-viewport-with-subsequent-script.php +++ b/plugins/embed-optimizer/tests/test-cases/single-spotify-embed-outside-viewport-with-subsequent-script.php @@ -35,7 +35,7 @@ ... -
+
diff --git a/plugins/embed-optimizer/tests/test-cases/single-twitter-embed-inside-viewport.php b/plugins/embed-optimizer/tests/test-cases/single-twitter-embed-inside-viewport.php index fb5b39df1c..2279286a1a 100644 --- a/plugins/embed-optimizer/tests/test-cases/single-twitter-embed-inside-viewport.php +++ b/plugins/embed-optimizer/tests/test-cases/single-twitter-embed-inside-viewport.php @@ -36,7 +36,7 @@ -
+
diff --git a/plugins/embed-optimizer/tests/test-cases/single-twitter-embed-outside-viewport.php b/plugins/embed-optimizer/tests/test-cases/single-twitter-embed-outside-viewport.php index 81bf2c2ae9..62088e25f9 100644 --- a/plugins/embed-optimizer/tests/test-cases/single-twitter-embed-outside-viewport.php +++ b/plugins/embed-optimizer/tests/test-cases/single-twitter-embed-outside-viewport.php @@ -34,7 +34,7 @@ ... -
+
diff --git a/plugins/embed-optimizer/tests/test-cases/single-wordpress-tv-embed-inside-viewport.php b/plugins/embed-optimizer/tests/test-cases/single-wordpress-tv-embed-inside-viewport.php index b802cb8632..9b6234d485 100644 --- a/plugins/embed-optimizer/tests/test-cases/single-wordpress-tv-embed-inside-viewport.php +++ b/plugins/embed-optimizer/tests/test-cases/single-wordpress-tv-embed-inside-viewport.php @@ -39,7 +39,7 @@ -
+
diff --git a/plugins/embed-optimizer/tests/test-cases/single-wordpress-tv-embed-outside-viewport.php b/plugins/embed-optimizer/tests/test-cases/single-wordpress-tv-embed-outside-viewport.php index f931034b62..f9087a8399 100644 --- a/plugins/embed-optimizer/tests/test-cases/single-wordpress-tv-embed-outside-viewport.php +++ b/plugins/embed-optimizer/tests/test-cases/single-wordpress-tv-embed-outside-viewport.php @@ -35,7 +35,7 @@ ... -
+
diff --git a/plugins/embed-optimizer/tests/test-cases/single-youtube-embed-inside-viewport.php b/plugins/embed-optimizer/tests/test-cases/single-youtube-embed-inside-viewport.php index df31dce205..6c322bc701 100644 --- a/plugins/embed-optimizer/tests/test-cases/single-youtube-embed-inside-viewport.php +++ b/plugins/embed-optimizer/tests/test-cases/single-youtube-embed-inside-viewport.php @@ -35,7 +35,7 @@ -
+
diff --git a/plugins/embed-optimizer/tests/test-cases/single-youtube-embed-outside-viewport.php b/plugins/embed-optimizer/tests/test-cases/single-youtube-embed-outside-viewport.php index 89151656d9..729f25ef2c 100644 --- a/plugins/embed-optimizer/tests/test-cases/single-youtube-embed-outside-viewport.php +++ b/plugins/embed-optimizer/tests/test-cases/single-youtube-embed-outside-viewport.php @@ -33,7 +33,7 @@ ... -
+
diff --git a/tests/class-optimization-detective-test-helpers.php b/tests/class-optimization-detective-test-helpers.php index eaa9210270..ce04b2ac60 100644 --- a/tests/class-optimization-detective-test-helpers.php +++ b/tests/class-optimization-detective-test-helpers.php @@ -50,8 +50,8 @@ public function populate_url_metrics( array $elements, bool $complete = true ): */ public function get_sample_dom_rect(): array { return array( - 'width' => 100.1, - 'height' => 100.2, + 'width' => 500.1, + 'height' => 500.2, 'x' => 100.3, 'y' => 100.4, 'top' => 0.1,