From 67197cc6e2bc809f57b029bbb6461b2c3c7de774 Mon Sep 17 00:00:00 2001 From: Gerardo Date: Tue, 7 Feb 2023 18:44:46 +0100 Subject: [PATCH 1/3] Mobile - Support Visual regression testing --- .../__device-tests__/.eslintrc.js | 6 +++++- .../__device-tests__/helpers/test-data.js | 19 +++++++++++++++++++ .../__device-tests__/pages/editor-page.js | 1 + .../jest_ui_test_environment.js | 6 ++++++ 4 files changed, 31 insertions(+), 1 deletion(-) diff --git a/packages/react-native-editor/__device-tests__/.eslintrc.js b/packages/react-native-editor/__device-tests__/.eslintrc.js index 7a9957b5fc572..17cf6b845966f 100644 --- a/packages/react-native-editor/__device-tests__/.eslintrc.js +++ b/packages/react-native-editor/__device-tests__/.eslintrc.js @@ -1,7 +1,11 @@ module.exports = { extends: '../.eslintrc.js', globals: { - editorPage: true, // Defined in 'jest_ui_test_environment.js' + // Defined in 'jest_ui_test_environment.js' + editorPage: true, + E2ETestData: true, + E2EUtils: true, + E2EBlockNames: true, }, rules: { 'jest/expect-expect': 'off', diff --git a/packages/react-native-editor/__device-tests__/helpers/test-data.js b/packages/react-native-editor/__device-tests__/helpers/test-data.js index db84a7ad02926..f87953e11aa3a 100644 --- a/packages/react-native-editor/__device-tests__/helpers/test-data.js +++ b/packages/react-native-editor/__device-tests__/helpers/test-data.js @@ -187,3 +187,22 @@ exports.lettersInParagraphBlock = ` exports.spacerBlock = ` `; + +exports.galleryBlock = ` + +`; diff --git a/packages/react-native-editor/__device-tests__/pages/editor-page.js b/packages/react-native-editor/__device-tests__/pages/editor-page.js index c78cc135c06ba..18334b405d892 100644 --- a/packages/react-native-editor/__device-tests__/pages/editor-page.js +++ b/packages/react-native-editor/__device-tests__/pages/editor-page.js @@ -821,6 +821,7 @@ const blockNames = { spacer: 'Spacer', verse: 'Verse', shortcode: 'Shortcode', + group: 'Group', }; module.exports = { initializeEditorPage, blockNames }; diff --git a/packages/react-native-editor/jest_ui_test_environment.js b/packages/react-native-editor/jest_ui_test_environment.js index 40095937e8629..f131aa8c6c6d1 100644 --- a/packages/react-native-editor/jest_ui_test_environment.js +++ b/packages/react-native-editor/jest_ui_test_environment.js @@ -3,7 +3,10 @@ */ const { initializeEditorPage, + blockNames, } = require( './__device-tests__/pages/editor-page' ); +const utils = require( './__device-tests__/helpers/utils' ); +const testData = require( './__device-tests__/helpers/test-data' ); /** * External dependencies @@ -16,6 +19,9 @@ class CustomEnvironment extends JSDOMEnvironment { try { await super.setup(); this.global.editorPage = await initializeEditorPage(); + this.global.editorPage.blockNames = blockNames; + this.global.E2EUtils = utils; + this.global.E2ETestData = testData; } catch ( error ) { // eslint-disable-next-line no-console console.error( 'E2E setup exception:', error ); From a5df02ce9e784e34ea43825a7cc235510f63d610 Mon Sep 17 00:00:00 2001 From: Gerardo Date: Mon, 13 Feb 2023 11:40:50 +0100 Subject: [PATCH 2/3] Mobile - Jest UI Config - Rename E2E globals to keep consistency --- packages/react-native-editor/jest_ui_test_environment.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react-native-editor/jest_ui_test_environment.js b/packages/react-native-editor/jest_ui_test_environment.js index f131aa8c6c6d1..2e245987ec77d 100644 --- a/packages/react-native-editor/jest_ui_test_environment.js +++ b/packages/react-native-editor/jest_ui_test_environment.js @@ -20,8 +20,8 @@ class CustomEnvironment extends JSDOMEnvironment { await super.setup(); this.global.editorPage = await initializeEditorPage(); this.global.editorPage.blockNames = blockNames; - this.global.E2EUtils = utils; - this.global.E2ETestData = testData; + this.global.e2eUtils = utils; + this.global.e2eTestData = testData; } catch ( error ) { // eslint-disable-next-line no-console console.error( 'E2E setup exception:', error ); From ec93dcadf5d9a7c2ce1210b992211d80243e6c70 Mon Sep 17 00:00:00 2001 From: Gerardo Date: Mon, 13 Feb 2023 11:51:06 +0100 Subject: [PATCH 3/3] Mobile - Update eslintrc config --- packages/react-native-editor/__device-tests__/.eslintrc.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/react-native-editor/__device-tests__/.eslintrc.js b/packages/react-native-editor/__device-tests__/.eslintrc.js index 17cf6b845966f..1b363c837f44d 100644 --- a/packages/react-native-editor/__device-tests__/.eslintrc.js +++ b/packages/react-native-editor/__device-tests__/.eslintrc.js @@ -3,9 +3,8 @@ module.exports = { globals: { // Defined in 'jest_ui_test_environment.js' editorPage: true, - E2ETestData: true, - E2EUtils: true, - E2EBlockNames: true, + e2eTestData: true, + e2eUtils: true, }, rules: { 'jest/expect-expect': 'off',