From 2737f22a3d84d334dd42f46ae1ba51c638b9c651 Mon Sep 17 00:00:00 2001 From: jasmussen Date: Mon, 17 Feb 2020 08:12:34 +0100 Subject: [PATCH 1/2] Try: Show metaboxes peeking in even on tiny screens. Fixes #19709. --- packages/edit-post/src/components/visual-editor/style.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/edit-post/src/components/visual-editor/style.scss b/packages/edit-post/src/components/visual-editor/style.scss index 0becd2e48cec6..77ec335ccdfbb 100644 --- a/packages/edit-post/src/components/visual-editor/style.scss +++ b/packages/edit-post/src/components/visual-editor/style.scss @@ -27,7 +27,7 @@ .edit-post-visual-editor .block-editor-writing-flow__click-redirect { // Allow the page to be scrolled with the last block in the middle. - min-height: 50vh; + min-height: 40vh; width: 100%; } From 92e94e71ee2fef54f2255db8f7244444ddc636b5 Mon Sep 17 00:00:00 2001 From: Riad Benguella Date: Fri, 21 Feb 2020 10:05:44 +0100 Subject: [PATCH 2/2] Try fixing the e2e test --- .../specs/editor/various/navigable-toolbar.test.js | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/packages/e2e-tests/specs/editor/various/navigable-toolbar.test.js b/packages/e2e-tests/specs/editor/various/navigable-toolbar.test.js index f10ad5f319002..e108828c31e63 100644 --- a/packages/e2e-tests/specs/editor/various/navigable-toolbar.test.js +++ b/packages/e2e-tests/specs/editor/various/navigable-toolbar.test.js @@ -50,11 +50,12 @@ describe.each( [ if ( ! isUnifiedToolbar ) { it( 'should not scroll page', async () => { while ( - await page.evaluate( - () => - wp.dom.getScrollContainer( document.activeElement ) - .scrollTop === 0 - ) + await page.evaluate( () => { + const scrollable = wp.dom.getScrollContainer( + document.activeElement + ); + return ! scrollable || scrollable.scrollTop === 0; + } ) ) { await page.keyboard.press( 'Enter' ); }