From 96f806012a09194895b5ac69d4048d50dea216c6 Mon Sep 17 00:00:00 2001 From: Courtney <9257264+cburton4@users.noreply.github.com> Date: Thu, 25 Jul 2019 16:28:12 -0400 Subject: [PATCH 1/3] Spinner Component: Added design documentation and image --- packages/components/src/spinner/README.md | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/packages/components/src/spinner/README.md b/packages/components/src/spinner/README.md index b4978f5f4607c2..71bd6301be475a 100644 --- a/packages/components/src/spinner/README.md +++ b/packages/components/src/spinner/README.md @@ -1,5 +1,16 @@ # Spinner +Spinners are used to notify users that their action is being processed. + +![Spinner component](https://wordpress.org/gutenberg/files/2019/07/spinner.png) + +## Best practices + +The spinner component should: + +- Notify users that their request has been received and the action will soon complete. +- The spinner component should be avoided to load a page or data. + ## Usage ```jsx From a49389502a41eac254ffb3f572ceb9895f089720 Mon Sep 17 00:00:00 2001 From: Courtney <9257264+cburton4@users.noreply.github.com> Date: Mon, 29 Jul 2019 11:11:14 -0400 Subject: [PATCH 2/3] Copy tweaks --- packages/components/src/spinner/README.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/components/src/spinner/README.md b/packages/components/src/spinner/README.md index 71bd6301be475a..a159173a62074e 100644 --- a/packages/components/src/spinner/README.md +++ b/packages/components/src/spinner/README.md @@ -1,6 +1,6 @@ # Spinner -Spinners are used to notify users that their action is being processed. +Spinners notify users that their action is being processed. ![Spinner component](https://wordpress.org/gutenberg/files/2019/07/spinner.png) @@ -8,8 +8,8 @@ Spinners are used to notify users that their action is being processed. The spinner component should: -- Notify users that their request has been received and the action will soon complete. -- The spinner component should be avoided to load a page or data. +- Signal to users that the processing of their request is underway and will soon complete. +- Not appear when pages or data are loading. ## Usage From ad474c43ae2ce11ad093f52006fdb6807e4cfb63 Mon Sep 17 00:00:00 2001 From: Courtney <9257264+cburton4@users.noreply.github.com> Date: Wed, 31 Jul 2019 13:56:46 -0400 Subject: [PATCH 3/3] Removed guidelines Removed guidelines, "Not appear when pages or data are loading." --- packages/components/src/spinner/README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/components/src/spinner/README.md b/packages/components/src/spinner/README.md index a159173a62074e..38d3c8ec1f39f4 100644 --- a/packages/components/src/spinner/README.md +++ b/packages/components/src/spinner/README.md @@ -9,7 +9,6 @@ Spinners notify users that their action is being processed. The spinner component should: - Signal to users that the processing of their request is underway and will soon complete. -- Not appear when pages or data are loading. ## Usage