From 00984968613a38d3ab03596fb205438d20fbe86c Mon Sep 17 00:00:00 2001 From: Jorge Date: Wed, 3 Apr 2019 09:48:34 +0100 Subject: [PATCH] Fix: media text vertical align fixture and block transforms structure. --- packages/e2e-tests/fixtures/block-transforms.js | 6 ++++++ .../core__media-text__vertical-align-bottom.html | 8 ++++---- .../core__media-text__vertical-align-bottom.json | 5 ++--- ...__media-text__vertical-align-bottom.parsed.json | 14 +++++++++++--- ...dia-text__vertical-align-bottom.serialized.html | 4 ++-- .../__snapshots__/block-transforms.test.js.snap | 6 ++++++ 6 files changed, 31 insertions(+), 12 deletions(-) diff --git a/packages/e2e-tests/fixtures/block-transforms.js b/packages/e2e-tests/fixtures/block-transforms.js index 4e81d0db5a22a..9fa130856191b 100644 --- a/packages/e2e-tests/fixtures/block-transforms.js +++ b/packages/e2e-tests/fixtures/block-transforms.js @@ -45,6 +45,12 @@ export const EXPECTED_TRANSFORMS = { 'Video', ], }, + 'core__media-text__vertical-align-bottom': { + originalBlock: 'Media & Text', + availableTransforms: [ + 'Image', + ], + }, 'core__media-text__video': { originalBlock: 'Media & Text', availableTransforms: [ diff --git a/packages/e2e-tests/fixtures/blocks/core__media-text__vertical-align-bottom.html b/packages/e2e-tests/fixtures/blocks/core__media-text__vertical-align-bottom.html index 639735b4c0579..5d6c03f6d9dad 100644 --- a/packages/e2e-tests/fixtures/blocks/core__media-text__vertical-align-bottom.html +++ b/packages/e2e-tests/fixtures/blocks/core__media-text__vertical-align-bottom.html @@ -1,12 +1,12 @@ - +
My alt text
+ src="data:image/jpeg;base64,/9j/2wBDAAMCAgICAgMCAgIDAwMDBAYEBAQEBAgGBgUGCQgKCgkICQkKDA8MCgsOCwkJDRENDg8QEBEQCgwSExIQEw8QEBD/yQALCAABAAEBAREA/8wABgAQEAX/2gAIAQEAAD8A0s8g/9k=" alt="My alt text" + />

My content

- \ No newline at end of file + diff --git a/packages/e2e-tests/fixtures/blocks/core__media-text__vertical-align-bottom.json b/packages/e2e-tests/fixtures/blocks/core__media-text__vertical-align-bottom.json index c32892010cc7f..ec93ddd17c912 100644 --- a/packages/e2e-tests/fixtures/blocks/core__media-text__vertical-align-bottom.json +++ b/packages/e2e-tests/fixtures/blocks/core__media-text__vertical-align-bottom.json @@ -7,8 +7,7 @@ "align": "wide", "mediaAlt": "My alt text", "mediaPosition": "left", - "mediaId": 11, - "mediaUrl": "http://localhost:8888/wp-content/uploads/2019/03/Dzts-v2X0AMxju_-1024x1024.jpg", + "mediaUrl": "data:image/jpeg;base64,/9j/2wBDAAMCAgICAgMCAgIDAwMDBAYEBAQEBAgGBgUGCQgKCgkICQkKDA8MCgsOCwkJDRENDg8QEBEQCgwSExIQEw8QEBD/yQALCAABAAEBAREA/8wABgAQEAX/2gAIAQEAAD8A0s8g/9k=", "mediaType": "image", "mediaWidth": 50, "isStackedOnMobile": false, @@ -29,6 +28,6 @@ "originalContent": "

My content

" } ], - "originalContent": "
\n\t
\n\t
\n\t\t\n\t
\n
" + "originalContent": "
\n\t
\n\t
\n\t\t\n\t
\n
" } ] diff --git a/packages/e2e-tests/fixtures/blocks/core__media-text__vertical-align-bottom.parsed.json b/packages/e2e-tests/fixtures/blocks/core__media-text__vertical-align-bottom.parsed.json index 95b8f5d3ec074..e37b694623531 100644 --- a/packages/e2e-tests/fixtures/blocks/core__media-text__vertical-align-bottom.parsed.json +++ b/packages/e2e-tests/fixtures/blocks/core__media-text__vertical-align-bottom.parsed.json @@ -2,7 +2,6 @@ { "blockName": "core/media-text", "attrs": { - "mediaId": 11, "mediaType": "image", "verticalAlignment": "bottom" }, @@ -20,11 +19,20 @@ ] } ], - "innerHTML": "\n
\n\t
\n\t
\n\t\t\n\t
\n
\n", + "innerHTML": "\n
\n\t
\n\t
\n\t\t\n\t
\n
\n", "innerContent": [ - "\n
\n\t
\n\t
\n\t\t", + "\n
\n\t
\n\t
\n\t\t", null, "\n\t
\n
\n" ] + }, + { + "blockName": null, + "attrs": {}, + "innerBlocks": [], + "innerHTML": "\n", + "innerContent": [ + "\n" + ] } ] diff --git a/packages/e2e-tests/fixtures/blocks/core__media-text__vertical-align-bottom.serialized.html b/packages/e2e-tests/fixtures/blocks/core__media-text__vertical-align-bottom.serialized.html index a3bd89af19025..07e4fc9a3dec7 100644 --- a/packages/e2e-tests/fixtures/blocks/core__media-text__vertical-align-bottom.serialized.html +++ b/packages/e2e-tests/fixtures/blocks/core__media-text__vertical-align-bottom.serialized.html @@ -1,5 +1,5 @@ - -
My alt text
+ +
My alt text

My content

diff --git a/packages/e2e-tests/specs/__snapshots__/block-transforms.test.js.snap b/packages/e2e-tests/specs/__snapshots__/block-transforms.test.js.snap index 13e2f3c192ccf..a6738f734bb85 100644 --- a/packages/e2e-tests/specs/__snapshots__/block-transforms.test.js.snap +++ b/packages/e2e-tests/specs/__snapshots__/block-transforms.test.js.snap @@ -328,6 +328,12 @@ exports[`Block transforms correctly transform block Media & Text in fixture core " `; +exports[`Block transforms correctly transform block Media & Text in fixture core__media-text__vertical-align-bottom into the Image block 1`] = ` +" +
\\"My
+" +`; + exports[`Block transforms correctly transform block Media & Text in fixture core__media-text__video into the Video block 1`] = ` "