Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reusable blocks are too tall #18901

Closed
ZebulanStanphill opened this issue Dec 4, 2019 · 0 comments · Fixed by #18902
Closed

Reusable blocks are too tall #18901

ZebulanStanphill opened this issue Dec 4, 2019 · 0 comments · Fixed by #18902
Assignees
@ZebulanStanphill
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@ZebulanStanphill
Copy link
Member

ZebulanStanphill commented Dec 4, 2019 •
edited
Loading

Description

Reusable blocks are too tall. I think #18732 introduced this issue due to the min-height: 50vw style it adds.

image

How to reproduce

  1. Create/insert a reusable block.
  2. Observe how tall it is.

Environment

  • WordPress 5.4-alpha-46811
  • Gutenberg master as of 0480528
  • Using Dissenter browser 0.70 (based on Chromium 78)
@ZebulanStanphill ZebulanStanphill added [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release labels Dec 4, 2019
@ZebulanStanphill ZebulanStanphill mentioned this issue Dec 4, 2019
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Dec 4, 2019
@ZebulanStanphill ZebulanStanphill mentioned this issue Dec 4, 2019
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZebulanStanphill ZebulanStanphill

Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix reusable blocks being too tall WordPress/gutenberg
1 participant
@ZebulanStanphill