Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest Posts Block - post title is not accessible when full post content is included #15376

Open
getdave opened this issue May 1, 2019 · 1 comment
Labels
[Block] Latest Posts Affects the Latest Posts Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@getdave
Copy link
Contributor

getdave commented May 1, 2019

When working on the updates to the Latest Posts Block I noticed that when the articles are displayed along with post content the markup isn't particularly accessible.

Screen Shot 2019-04-30 at 13 54 18

In this context my questions are:

  1. Should the article be wrapped in an <article> tag as it is now a full piece of content and not just a title or title + excerpt. If feels like syndicatable content in its own right.
  2. Given the above, should the title of the post be wrapped in a valid heading level tag? You will see from the screenshot above that if the article content contains headings (which it likely will) then the markup of the Block becomes quite confusing. It might be less so if it were within an article.

Originally posted by @getdave in #14627 (comment)

@getdave getdave added [Block] Latest Posts Affects the Latest Posts Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Accessibility Feedback Need input from accessibility labels May 1, 2019
@afercia
Copy link
Contributor

afercia commented May 8, 2019

Interesting issue @getdave. To my understanding, this happens only when the block setting "Show full post" is on.

When this happens, I'd be more worried for the headings hierarchy and general semantics of the content which becomes... messy? 🙂 The headings hierarchy can be disrupted by the headings within the latests posts content. The latests posts can basically contain anything, I'm afraid there's really no way to guarantee correct semantics. Wondering if the setting "Show full post" is a good idea in the first place.

That said, I may be wrong, but I don't know of any assistive technology that communicates the semantics of <article>.

@afercia afercia removed the Needs Accessibility Feedback Need input from accessibility label May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Latest Posts Affects the Latest Posts Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

No branches or pull requests

2 participants