Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible typo here on repository-management.md #15174

Closed
saracope opened this issue Apr 25, 2019 · 1 comment · Fixed by #15611
Closed

Possible typo here on repository-management.md #15174

saracope opened this issue Apr 25, 2019 · 1 comment · Fixed by #15611
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Developer Documentation Documentation for developers

Comments

@saracope
Copy link
Contributor

Describe the bug
In the *Design Review * section, the first bullet says
- Something based on a previous design, to check is as that design.

This doesn't make sense to me, specifically the second part at check is as. I think there's something missing here, but not sure what.

To reproduce
repository-management.md

Expected behavior
Clear writing

If there's a change needed, I'd be happy to PR it once someone gives clarity about what the sentence should be.

@aduth aduth added [Type] Developer Documentation Documentation for developers Good First Issue An issue that's suitable for someone looking to contribute for the first time labels Apr 25, 2019
@aduth
Copy link
Member

aduth commented Apr 25, 2019

If there's a change needed, I'd be happy to PR it once someone gives clarity about what the sentence should be.

My guess is that it is intended to read along the lines of:

Something based on a previous design, to check that it is as that design prescribes.

(Emphasis added for missing words)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants