Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts: Missing corejs version in Babel config #15138

Closed
swissspidy opened this issue Apr 24, 2019 · 0 comments · Fixed by #15139
Closed

Scripts: Missing corejs version in Babel config #15138

swissspidy opened this issue Apr 24, 2019 · 0 comments · Fixed by #15139
Assignees
Labels
[Package] Babel preset /packages/babel-preset-default [Package] Scripts /packages/scripts [Type] Bug An existing feature does not function as intended

Comments

@swissspidy
Copy link
Member

Describe the bug
I am trying to use @wordpress/scripts for unit tests. Still running into #13364, but there's also another issue when running wp-scripts test-unit-js:

WARNING: We noticed you're using the `useBuiltIns` option without declaring a core-js version. Currently, we assume version 2.x when no version is passed. Since this default version will likely change in future versions of Babel, we recommend explicitly setting the core-js version you are using via the `corejs` option.

You should also be sure that the version you pass to the `corejs` option matches the version specified in your `package.json`'s `dependencies` section. If it doesn't, you need to run one of the following commands:

  npm install --save core-js@2    npm install --save core-js@3
  yarn add core-js@2              yarn add core-js@3

Indeed, @wordpress/babel-preset-default uses useBuiltIns when running tests, but does not specify the corejs version:

if ( isTestEnv ) {
opts.useBuiltIns = 'usage';

To reproduce
Steps to reproduce the behavior:

  1. Install wp-scripts in your project.
  2. Try to run some tests
  3. Notice error

Expected behavior

The Babel config should add the corejs option in that scenario.

@swissspidy swissspidy added [Package] Babel preset /packages/babel-preset-default [Package] Scripts /packages/scripts [Type] Bug An existing feature does not function as intended labels Apr 24, 2019
@gziolo gziolo added the [Status] In Progress Tracking issues with work in progress label Apr 24, 2019
@gziolo gziolo removed [Status] In Progress Tracking issues with work in progress labels Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Babel preset /packages/babel-preset-default [Package] Scripts /packages/scripts [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants