From 286541ff4d04ab7a362a6de8f8bd9f744ae1e47c Mon Sep 17 00:00:00 2001
From: Carlos Bravo <carlos.bravo@automattic.com>
Date: Wed, 14 Jun 2023 18:49:15 +0200
Subject: [PATCH] The default option changes how we have to do the e2e

---
 packages/block-editor/src/hooks/behaviors.js  |  3 +-
 .../specs/editor/various/behaviors.spec.js    | 81 -------------------
 2 files changed, 1 insertion(+), 83 deletions(-)

diff --git a/packages/block-editor/src/hooks/behaviors.js b/packages/block-editor/src/hooks/behaviors.js
index cb790861833d7..ab140837474c6 100644
--- a/packages/block-editor/src/hooks/behaviors.js
+++ b/packages/block-editor/src/hooks/behaviors.js
@@ -65,7 +65,7 @@ function BehaviorsControl( {
 	];
 
 	// If every behavior is disabled, do not show the behaviors inspector control.
-	if ( options.length === 0 ) {
+	if ( behaviorsOptions.length === 0 ) {
 		return null;
 	}
 	// Block behaviors take precedence over theme behaviors.
@@ -89,7 +89,6 @@ function BehaviorsControl( {
 		<InspectorControls group="advanced">
 			<SelectControl
 				label={ __( 'Behaviors' ) }
-				// At the moment we are only supporting one behavior (Lightbox)
 				value={ value() }
 				options={ options }
 				onChange={ onChange }
diff --git a/test/e2e/specs/editor/various/behaviors.spec.js b/test/e2e/specs/editor/various/behaviors.spec.js
index 51fd5abd4a35d..3157a41edacee 100644
--- a/test/e2e/specs/editor/various/behaviors.spec.js
+++ b/test/e2e/specs/editor/various/behaviors.spec.js
@@ -49,43 +49,6 @@ test.describe( 'Testing behaviors functionality', () => {
 		await page.waitForLoadState();
 	} );
 
-	test( '`No Behaviors` should be the default as defined in the core theme.json', async ( {
-		admin,
-		editor,
-		requestUtils,
-		page,
-		behaviorUtils,
-	} ) => {
-		await requestUtils.activateTheme( 'twentytwentyone' );
-		await admin.createNewPost();
-		const media = await behaviorUtils.createMedia();
-		await editor.insertBlock( {
-			name: 'core/image',
-			attributes: {
-				alt: filename,
-				id: media.id,
-				url: media.source_url,
-			},
-		} );
-
-		await editor.openDocumentSettingsSidebar();
-		const editorSettings = page.getByRole( 'region', {
-			name: 'Editor settings',
-		} );
-		await editorSettings
-			.getByRole( 'button', { name: 'Advanced' } )
-			.click();
-		const select = editorSettings.getByRole( 'combobox', {
-			name: 'Behavior',
-		} );
-
-		// By default, no behaviors should be selected.
-		await expect( select ).toHaveValue( '' );
-
-		// By default, you should be able to select the Lightbox behavior.
-		await expect( select.getByRole( 'option' ) ).toHaveCount( 3 );
-	} );
-
 	test( 'Behaviors UI can be disabled in the `theme.json`', async ( {
 		admin,
 		editor,
@@ -173,50 +136,6 @@ test.describe( 'Testing behaviors functionality', () => {
 		// lightbox even though the theme.json has it set to false.
 	} );
 
-	test( 'You can set the default value for the behaviors in the theme.json', async ( {
-		admin,
-		editor,
-		requestUtils,
-		page,
-		behaviorUtils,
-	} ) => {
-		// In this theme, the default value for settings.behaviors.blocks.core/image.lightbox is `true`.
-		await requestUtils.activateTheme( 'behaviors-enabled' );
-		await admin.createNewPost();
-		const media = await behaviorUtils.createMedia();
-
-		await editor.insertBlock( {
-			name: 'core/image',
-			attributes: {
-				alt: filename,
-				id: media.id,
-				url: media.source_url,
-			},
-		} );
-
-		await editor.openDocumentSettingsSidebar();
-		const editorSettings = page.getByRole( 'region', {
-			name: 'Editor settings',
-		} );
-		await editorSettings
-			.getByRole( 'button', { name: 'Advanced' } )
-			.click();
-		const select = editorSettings.getByRole( 'combobox', {
-			name: 'Behavior',
-		} );
-
-		// The behaviors dropdown should be present and the value should be set to
-		// `lightbox`.
-		await expect( select ).toHaveValue( 'lightbox' );
-
-		// There should be 2 options available: `No behaviors` and `Lightbox`.
-		await expect( select.getByRole( 'option' ) ).toHaveCount( 3 );
-
-		// We can change the value of the behaviors dropdown to `No behaviors`.
-		await select.selectOption( { label: 'No behaviors' } );
-		await expect( select ).toHaveValue( '' );
-	} );
-
 	test( 'Lightbox behavior is disabled if the Image has a link', async ( {
 		admin,
 		editor,