From 1b85a57317df6925bc421b05c8e4bc02c36f0514 Mon Sep 17 00:00:00 2001 From: Marin Atanasov <8436925+tyxla@users.noreply.github.com> Date: Fri, 10 Jun 2022 12:13:39 +0300 Subject: [PATCH] Lodash: Refactor away from _.stubTrue and _.stubFalse (#41625) --- .../src/api/parser/apply-block-deprecated-versions.js | 11 ++++++++++- packages/blocks/src/api/validation/index.js | 4 ++-- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/packages/blocks/src/api/parser/apply-block-deprecated-versions.js b/packages/blocks/src/api/parser/apply-block-deprecated-versions.js index 7a7b2c34d2055..3b0b34090ce9a 100644 --- a/packages/blocks/src/api/parser/apply-block-deprecated-versions.js +++ b/packages/blocks/src/api/parser/apply-block-deprecated-versions.js @@ -1,7 +1,7 @@ /** * External dependencies */ -import { omit, stubFalse, castArray } from 'lodash'; +import { omit, castArray } from 'lodash'; /** * Internal dependencies @@ -11,6 +11,15 @@ import { validateBlock } from '../validation'; import { getBlockAttributes } from './get-block-attributes'; import { applyBuiltInValidationFixes } from './apply-built-in-validation-fixes'; +/** + * Function that takes no arguments and always returns false. + * + * @return {boolean} Always returns false. + */ +function stubFalse() { + return false; +} + /** * Given a block object, returns a new copy of the block with any applicable * deprecated migrations applied, or the original block if it was both valid diff --git a/packages/blocks/src/api/validation/index.js b/packages/blocks/src/api/validation/index.js index cca4ddbe90904..2bda73c5c0841 100644 --- a/packages/blocks/src/api/validation/index.js +++ b/packages/blocks/src/api/validation/index.js @@ -2,7 +2,7 @@ * External dependencies */ import { Tokenizer } from 'simple-html-tokenizer'; -import { identity, xor, fromPairs, isEqual, includes, stubTrue } from 'lodash'; +import { identity, xor, fromPairs, isEqual, includes } from 'lodash'; /** * WordPress dependencies @@ -418,7 +418,7 @@ export const isEqualAttributesOfName = { // For each boolean attribute, mere presence of attribute in both is enough // to assume equivalence. ...fromPairs( - BOOLEAN_ATTRIBUTES.map( ( attribute ) => [ attribute, stubTrue ] ) + BOOLEAN_ATTRIBUTES.map( ( attribute ) => [ attribute, () => true ] ) ), };