From b1600db1068da73f006283e32c7d72bd8f5bd328 Mon Sep 17 00:00:00 2001 From: Dennis Heimbigner Date: Mon, 13 Jun 2022 13:14:55 -0600 Subject: [PATCH 1/2] Fix nc_def_var_fletcher32 operation re: Github Issue https://github.com/Unidata/netcdf-c/issues/2401 The nc_def_var_fletcher32 code in hdf5 is always setting fletcher32 when invoked. Fix is to properly test value of the fletcher32 argument. --- libhdf5/hdf5var.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libhdf5/hdf5var.c b/libhdf5/hdf5var.c index 287d5dfef2..0dfd9ef808 100644 --- a/libhdf5/hdf5var.c +++ b/libhdf5/hdf5var.c @@ -542,7 +542,7 @@ nc_def_var_extra(int ncid, int varid, int *shuffle, int *unused1, } /* Fletcher32 checksum error protection? */ - if (fletcher32 && fletcher32) { + if (fletcher32 && *fletcher32) { retval = nc_inq_var_filter_info(ncid,varid,H5Z_FILTER_FLETCHER32,NULL,NULL); if(!retval || retval == NC_ENOFILTER) { if((retval = nc_def_var_filter(ncid,varid,H5Z_FILTER_FLETCHER32,0,NULL))) return retval; From 610c8aacb4b909d1525e871a343fd2eefb9d4c9a Mon Sep 17 00:00:00 2001 From: Dennis Heimbigner Date: Mon, 13 Jun 2022 14:12:47 -0600 Subject: [PATCH 2/2] Update release notes --- RELEASE_NOTES.md | 1 + 1 file changed, 1 insertion(+) diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index a187b42353..7762c608b9 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -7,6 +7,7 @@ This file contains a high-level description of this package's evolution. Release ## 4.8.2 - TBD +* [Bug Fix] Fix the nc_def_var_fletcher32 code in hdf5 to properly test value of the fletcher32 argument. See [Github #2403](https://github.com/Unidata/netcdf-c/pull/2403). * [Enhancement] Improve filter installation process to avoid use of an extra shell script. See [Github #2348](https://github.com/Unidata/netcdf-c/pull/2348). * [Bug Fix] Get "make distcheck" to work See [Github #/2343](https://github.com/Unidata/netcdf-c/pull/2343). * [Enhancement] Allow the read/write of JSON-valued Zarr attributes to allow