{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":565803888,"defaultBranch":"main","name":"TeferiTheGathering","ownerLogin":"Typing-Monkeys","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2022-11-14T11:08:52.000Z","ownerAvatar":"https://github.com/avatars/u/72442731?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1678378947.086529","currentOid":""},"activityList":{"items":[{"before":"97b7417d09eac90b17de7d1abf96d7f4b14a55e0","after":null,"ref":"refs/heads/Haste","pushedAt":"2023-03-09T16:22:27.086Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"ncvescera","name":"Nicolò Vescera","path":"/ncvescera","primaryAvatarUrl":"https://github.com/avatars/u/10250769?s=80&v=4"}},{"before":"910d826ce584eb3322a37ee2ff37a97949f78d34","after":null,"ref":"refs/heads/trippel-strike","pushedAt":"2023-03-09T16:22:24.640Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"ncvescera","name":"Nicolò Vescera","path":"/ncvescera","primaryAvatarUrl":"https://github.com/avatars/u/10250769?s=80&v=4"}},{"before":"eb1d86dc5e4b01f594d102e8dbd3faf3c7f285f5","after":null,"ref":"refs/heads/defender","pushedAt":"2023-03-09T16:22:22.769Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"ncvescera","name":"Nicolò Vescera","path":"/ncvescera","primaryAvatarUrl":"https://github.com/avatars/u/10250769?s=80&v=4"}},{"before":"5d79faf600d7d1253e64975b2a51334fed7e199d","after":null,"ref":"refs/heads/sourcery-fix","pushedAt":"2023-03-09T16:22:04.628Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"ncvescera","name":"Nicolò Vescera","path":"/ncvescera","primaryAvatarUrl":"https://github.com/avatars/u/10250769?s=80&v=4"}},{"before":"d4abf4d6616f1fdefece605c10135cba5ec48dff","after":null,"ref":"refs/heads/testing","pushedAt":"2023-03-09T16:22:02.259Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"ncvescera","name":"Nicolò Vescera","path":"/ncvescera","primaryAvatarUrl":"https://github.com/avatars/u/10250769?s=80&v=4"}},{"before":"2a85e43c59a2b7e60ecd192b31a02d7f5c58c94f","after":null,"ref":"refs/heads/documentazione","pushedAt":"2023-03-09T16:21:56.196Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"ncvescera","name":"Nicolò Vescera","path":"/ncvescera","primaryAvatarUrl":"https://github.com/avatars/u/10250769?s=80&v=4"}},{"before":"62407d63882989e7198e733944d1f4f19402a75a","after":null,"ref":"refs/heads/flash","pushedAt":"2023-03-09T16:21:54.443Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"ncvescera","name":"Nicolò Vescera","path":"/ncvescera","primaryAvatarUrl":"https://github.com/avatars/u/10250769?s=80&v=4"}},{"before":"fce3fba0704f4ae16a6febbd401c65d4a03761b8","after":null,"ref":"refs/heads/deathtouch","pushedAt":"2023-03-09T16:21:52.167Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"ncvescera","name":"Nicolò Vescera","path":"/ncvescera","primaryAvatarUrl":"https://github.com/avatars/u/10250769?s=80&v=4"}},{"before":"60b49539b72c7aa7ca487d16b4552aac15ec7f10","after":"7aea289f8b57d197c556a662fc828325eabcaa1c","ref":"refs/heads/main","pushedAt":"2023-03-09T14:40:29.589Z","pushType":"pr_merge","commitsCount":5,"pusher":{"login":"CristianCosci","name":"Cristian Cosci","path":"/CristianCosci","primaryAvatarUrl":"https://github.com/avatars/u/44636000?s=80&v=4"},"commit":{"message":"HotFix - Sorcery (#33)\n\nHotfix per evitare che il cast delle Instant/Sorcery causi il\r\ncrash/soft-lock del game.\r\n\r\n## In depth 🔍 \r\n\r\n### Sorcery - NullPointerException\r\n\r\nLa rimozione della riga seguente e le successive modifiche impedisco\r\nalla Sorcery di causare NullPointerException nelle succesive regole.\r\n``` diff\r\n\r\n\t$p: Player(id == $id)\r\n\t$listaSottoTipi: LinkedList() from $spell.getSubtype()\r\n-       $sottoTipo : String() from $listaSottoTipi\r\nthen\r\n\tfor (String sottoTipo : $listaSottoTipi) {\r\n\t\tif(sottoTipo == \"Aura\"){\r\n\t\t\tSystem.out.println(\"AURA\");\r\n\t\t\t$scs.add(\"601.2cfase1\");\r\n\t\t\t$scs.add(\"601.2cfase2\");\t\r\n```\r\n\r\nLa Sorcery a nostra disposizione, _Addle_, non aveva nessun sottotipo.\r\nQuesto impediva alla regola `601.2c` di triggerare.\r\n\r\n\r\nhttps://github.com/Typing-Monkeys/TeferiTheGathering/blob/91b7f695201c958fd3e1357d3a3a0ed0551f0497/mtgengine/src/main/resources/rules/Rules.drl#L5501-L5520\r\n\r\n### Instant/Sorcery - SoftLock\r\n\r\nLa regola che finalizzava il cast delle Spell Instant, aveva un problema\r\nnel `when`: la condizione `resolvingSpell.isPermanent == null` era\r\nmalposta in quanto bisogna controllare che sia `false` !\r\n\r\n```diff\r\nagenda-group \"general\"\r\nno-loop true \r\n\twhen\r\n-\t\t$g: Game(stage == Game.GAME_STAGE, resolvingSpell != null, resolvingSpell.isPermanent == null, $id: resolvingSpell.idController)\r\n+\t\t$g: Game(stage == Game.GAME_STAGE, resolvingSpell != null, resolvingSpell.isPermanent == false, $id: resolvingSpell.idController)\r\n\t\t$p: Player(id == $id)\r\n```\r\n\r\n\r\nhttps://github.com/Typing-Monkeys/TeferiTheGathering/blob/91b7f695201c958fd3e1357d3a3a0ed0551f0497/mtgengine/src/main/resources/rules/Rules.drl#L7133-L7154","shortMessageHtmlLink":"HotFix - Sorcery (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1593002647\" data-permission-text=\"Title is private\" data-url=\"https://github.com/Typing-Monkeys/TeferiTheGathering/issues/33\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/Typing-Monkeys/TeferiTheGathering/pull/33/hovercard\" href=\"https://github.com/Typing-Monkeys/TeferiTheGathering/pull/33\">#33</a>)"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAADAAtdqQA","startCursor":null,"endCursor":null}},"title":"Activity · Typing-Monkeys/TeferiTheGathering"}