Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turfjs.org/docs/ is broken #124

Closed
andrewharvey opened this issue Nov 21, 2017 · 13 comments
Closed

turfjs.org/docs/ is broken #124

andrewharvey opened this issue Nov 21, 2017 · 13 comments
Labels

Comments

@andrewharvey
Copy link

The docs for turf used to be at http://turfjs.org/docs/ right? Now that's broken, http://turfjs.org/docs works, so perhaps this needs a redirect?

@DenisCarriere
Copy link
Member

Correct, I think a redirect would be ideal.

http://turfjs.org/docs/

image

@DenisCarriere
Copy link
Member

@rowanwins Any thoughts on how we can handle that with VueJS?.. 🤔

@rowanwins
Copy link
Member

Think I should be able to manage it

@andrewharvey
Copy link
Author

If that redirect could retain the #params that would be ideal. Because a lot of links in the wild (eg here) like this http://turfjs.org/docs/#linesegment should still end up at that point in the docs.

@rowanwins
Copy link
Member

Roger that, will see how I go, thanks @andrewharvey . I did manage to kind of get things tidied last night but then got distracted trying to fix the bundle size :)

@DenisCarriere
Copy link
Member

DenisCarriere commented Nov 22, 2017

@andrewharvey 👍 For sure, we should preserve the previous URL references of TurfJS that way there's less broken links in the wild.

@andrewharvey
Copy link
Author

http://turfjs.org/docs/ currently returns a 404. This is breaking a lot of links in the wild.

@rowanwins
Copy link
Member

Yeah sorry @andrewharvey - still trying to find time to get on to this, the joy of trying to prioritise open-source work at 10pm :)

@andrewharvey
Copy link
Author

@rowanwins I understand and realise we're all volunteers here. Could we re-instate the old docs until this is resolved, that takes the time pressure off this and means links aren't broken? Then once this is fixed you can roll out the new docs once again.

@rowanwins
Copy link
Member

Let me take a look tonight @andrewharvey and I'll see if I can get it sorted. Unfortunantly even reverting is challenging because the old docs were for pre-v5 which means they didn't say anything about the options object.

@DenisCarriere
Copy link
Member

@rowanwins I did some changes to fix this... hopefully it didn't break anything.. 🤞 (unfortunately I'm going to bed and I won't be able to test this until tomorrow)

@DenisCarriere
Copy link
Member

The website should be working as intended again:

The following links work:

@andrewharvey
Copy link
Author

Thanks for fixing this!

One minor point, the docs used to accept lower case but now they don't so links in the wild like http://turfjs.org/docs/#linesegment don't go to the correct anchor, it's now http://turfjs.org/docs/#lineSegment. But at least they get to the docs page now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants