Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Godot crashes when saving storage file after using importer. #339

Closed
axedaddy opened this issue Mar 15, 2024 · 1 comment
Closed

Godot crashes when saving storage file after using importer. #339

axedaddy opened this issue Mar 15, 2024 · 1 comment
Labels
duplicate This issue or pull request already exists

Comments

@axedaddy
Copy link

Terrain3D version

v0.9.1

System information

Godot v4.2.1.stable.mono - Windows 10.0.22631 - Vulkan (Forward+) - dedicated NVIDIA RTX A2000 (NVIDIA; 31.0.15.5123) - 12th Gen Intel(R) Core(TM) i7-12700 (20 Threads)

Is the issue reproducable in the demo?

Not applicable

Issue description

Godot crashes when saving storage as .res. I'm not seeing this issue with smaller .exr files, this larger one causes the issue. The terrain successfully load's and I can navigate around it in the editor, only when saving storage as a .res does it then crash. Saving as .tres is OK, albeit slow.

note my .exr is 117MB - I'm not able to attach it here due to size limitations.

Steps to reproduce

  1. New godot project.
  2. open importer.tscn
  3. Add my .exr
  4. run import
    core/variant/variant_utility.cpp:1091 - Terrain3DStorage::import_images: (7168, 12288) image will not fit at (0, 0, 0). Try (-3584, -6144) to center
  5. set import position x=-3584, z=-6144
  6. run import
  7. save storage as, name as .res (see screen shot)
    After about 5sec Godot closes.

Screenshot 2024-03-15 214518b
Screenshot 2024-03-15 214201

Logs

Note: I did attempt to enable logging. No log file in appdata/roaming/godot, but I have attached a screen shot of the console.
I can provide the .exr on request (117MB).

Screenshot 2024-03-15_godotlog

@axedaddy axedaddy changed the title Godot crashes when saving storage Godot crashes when saving storage file after using importer. Mar 15, 2024
@TokisanGames
Copy link
Owner

Duplicate #159
You can import the terrain at runtime without saving. Or use a smaller terrain, eg segments in different scenes. Or wait until Godot fixes the bug.
In the future, crashes that haven't been reported yet should always be tested against the latest nightly build.

@TokisanGames TokisanGames closed this as not planned Won't fix, can't repro, duplicate, stale Mar 15, 2024
@TokisanGames TokisanGames added the duplicate This issue or pull request already exists label Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants