Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit undo/redo to only backup modified maps #165

Closed
TokisanGames opened this issue Jul 26, 2023 · 0 comments · Fixed by #374
Closed

Limit undo/redo to only backup modified maps #165

TokisanGames opened this issue Jul 26, 2023 · 0 comments · Fixed by #374
Assignees
Labels
enhancement New feature or request important High priority
Milestone

Comments

@TokisanGames
Copy link
Owner

TokisanGames commented Jul 26, 2023

Currently undo/redo retains everything, which is fine for ~10 regions. I haven't noticed any issues, but surely, we'll run into problems with speed or memory consumption when working with much larger terrains.

We don't have a per region dirty flag. Currently it's map type only.

There might be a challenge when creating regions in the middle of painting or at least it was a challenge before when getting us to this point.


Update since f626dc1: Undo/redo now only retains info for the current tool. No longer all map types for all regions, now it is just height maps for sculpting tools, control maps for texture tools.

What is remaining is limiting undo/redo to regions modified, which should be addressed by, or after #374. Perhaps the editing brush can be continually adding regions to the snapshot as the brush goes over them.

@TokisanGames TokisanGames added the enhancement New feature or request label Jul 26, 2023
@TokisanGames TokisanGames added this to the Stable milestone Jul 26, 2023
@TokisanGames TokisanGames modified the milestones: 1.0, 0.9.1 Dec 16, 2023
@TokisanGames TokisanGames modified the milestones: 0.9.1, 0.9.2, Beta 0.9.x Feb 2, 2024
@TokisanGames TokisanGames added the good first issue Good for newcomers label Apr 22, 2024
@TokisanGames TokisanGames removed the good first issue Good for newcomers label Jun 1, 2024
@TokisanGames TokisanGames added the important High priority label Jul 29, 2024
@TokisanGames TokisanGames self-assigned this Jul 29, 2024
@TokisanGames TokisanGames changed the title Limit undo/redo to only save modified maps Limit undo/redo to only backup modified maps Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request important High priority
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant