{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":103561685,"defaultBranch":"main","name":"roslyn","ownerLogin":"ToddGrun","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2017-09-14T17:28:03.000Z","ownerAvatar":"https://github.com/avatars/u/6785178?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1726084861.0","currentOid":""},"activityList":{"items":[{"before":"b4a526733c26e0b58ae34adf113ab6a88fa33536","after":"6b966a92989ec20b39a13287110b585758a7d98a","ref":"refs/heads/dev/toddgrun/FixTypoInRequestTelemetryLogger2","pushedAt":"2024-09-13T15:24:19.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ToddGrun","name":"Todd Grunke","path":"/ToddGrun","primaryAvatarUrl":"https://github.com/avatars/u/6785178?s=80&v=4"},"commit":{"message":"try converting to int before placing in log","shortMessageHtmlLink":"try converting to int before placing in log"}},{"before":"fb8430cb66e71f9d310b3599cfe1d5daf58e47ab","after":"b4a526733c26e0b58ae34adf113ab6a88fa33536","ref":"refs/heads/dev/toddgrun/FixTypoInRequestTelemetryLogger2","pushedAt":"2024-09-13T14:03:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ToddGrun","name":"Todd Grunke","path":"/ToddGrun","primaryAvatarUrl":"https://github.com/avatars/u/6785178?s=80&v=4"},"commit":{"message":"temp commit","shortMessageHtmlLink":"temp commit"}},{"before":null,"after":"bde9e3c09e15e2a95c8b64db89db920e48e13fe6","ref":"refs/heads/dev/toddgrun/9-11-ExtractMethodPerf","pushedAt":"2024-09-11T20:01:01.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ToddGrun","name":"Todd Grunke","path":"/ToddGrun","primaryAvatarUrl":"https://github.com/avatars/u/6785178?s=80&v=4"},"commit":{"message":"temp commit","shortMessageHtmlLink":"temp commit"}},{"before":null,"after":"fb8430cb66e71f9d310b3599cfe1d5daf58e47ab","ref":"refs/heads/dev/toddgrun/FixTypoInRequestTelemetryLogger2","pushedAt":"2024-09-11T15:07:06.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ToddGrun","name":"Todd Grunke","path":"/ToddGrun","primaryAvatarUrl":"https://github.com/avatars/u/6785178?s=80&v=4"},"commit":{"message":"This should be using TimeSpan.TotalMilliseconds, not TimeSpan.Milliseconds.","shortMessageHtmlLink":"This should be using TimeSpan.TotalMilliseconds, not TimeSpan.Millise…"}},{"before":"70246b1ec5344a051d7d7e617b7abc9e0398aca0","after":"c561e0b4d872de729128b0962db73026ba534b2a","ref":"refs/heads/dev/toddgrun/FixTypoInRequestTelemetryLogger","pushedAt":"2024-09-11T15:03:40.000Z","pushType":"push","commitsCount":18,"pusher":{"login":"ToddGrun","name":"Todd Grunke","path":"/ToddGrun","primaryAvatarUrl":"https://github.com/avatars/u/6785178?s=80&v=4"},"commit":{"message":"Merge branch 'dev/toddgrun/FixTypoInRequestTelemetryLogger' of https://github.com/toddgrun/roslyn into dev/toddgrun/FixTypoInRequestTelemetryLogger","shortMessageHtmlLink":"Merge branch 'dev/toddgrun/FixTypoInRequestTelemetryLogger' of <a href=\"https://github.com/toddgrun/roslyn\">https:…</a>"}},{"before":null,"after":"70246b1ec5344a051d7d7e617b7abc9e0398aca0","ref":"refs/heads/dev/toddgrun/FixTypoInRequestTelemetryLogger","pushedAt":"2024-09-09T16:47:59.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ToddGrun","name":"Todd Grunke","path":"/ToddGrun","primaryAvatarUrl":"https://github.com/avatars/u/6785178?s=80&v=4"},"commit":{"message":"Fix typo in RequestTelemetryLogger.UpdateTelemetryData\n\nThis should be using TimeSpan.TotalMilliseconds, not TimeSpan.Milliseconds.","shortMessageHtmlLink":"Fix typo in RequestTelemetryLogger.UpdateTelemetryData"}},{"before":null,"after":"07230064c5c71f5bf29b0f514af2e14ea8ca3369","ref":"refs/heads/dev/toddgrun/FixTypoIn_ProjectCodeModelFactory.ProcessNextDocumentBatchAsync","pushedAt":"2024-09-08T17:29:31.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ToddGrun","name":"Todd Grunke","path":"/ToddGrun","primaryAvatarUrl":"https://github.com/avatars/u/6785178?s=80&v=4"},"commit":{"message":"Fix typo in ProjectCodeModelFactory.ProcessNextDocumentBatchAsync\n\nI was looking at this code when inspecting tasks remaining during shutdown. Using Ticks means this code pretty much calls Listener.Delay on every loop iteration.","shortMessageHtmlLink":"Fix typo in ProjectCodeModelFactory.ProcessNextDocumentBatchAsync"}},{"before":null,"after":"f116eedc0f4c4e1f6edb19a3a3b50f6cdf5e35b0","ref":"refs/heads/dev/toddgrun/release-dev17.11-CancellationToken","pushedAt":"2024-09-06T18:26:08.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ToddGrun","name":"Todd Grunke","path":"/ToddGrun","primaryAvatarUrl":"https://github.com/avatars/u/6785178?s=80&v=4"},"commit":{"message":"Remove the cancellation token from the calculation of InProgressState.LazyStaleCompilationWithGeneratedDocuments (#75001)\n\n* Remove strong the cancellation token used in the calculation of InProgressState.LazyStaleCompilationWithGeneratedDocuments\r\n\r\nThis will hopefully address multiple recent feedback tickets around Go To Definition occasionally failing. The umbrella pri 0 feedback ticket is https://developercommunity.visualstudio.com/t/Go-to-definition-doesnt-work/10729503\r\n\r\nI was able to reproduce this by following the repro outlined by Garry in the feedback ticket, using the \"Code Search\" window and doing go to definition multiple times.\r\n\r\nThe issue here is that RegularCompilationTracker.FinalizeCompilationWorkerAsync tries to get the value from the Lazy inProgressState.LazyStaleCompilationWithGeneratedDocuments. This lazy holds onto an action that uses a CancellationToken that has already been cancelled, whereas the CancellationToken used by FinalizeCompilationWorkerAsync has not been cancelled. When the action for the lazy is performed, the corresponding OperationCanceledException ends up escaping out of FinalizeCompilationWorker due to the FatalError.ReportAndPropagateUnlessCanceled exception clause failing due to the cancellation token passed into FinalizeCompilationWorkerAsync not being in a cancelled state.\r\n\r\nThe offending Lazy is constructed by RegularCompilationTracker.WithDoNotCreateCreationPolicy's call to the InProgressState ctor. Instead of passing a closure capturing a cancellation token, I've changed the code to instead use CancellableLazy, which takes in a cancellation token at the time the value is requested.","shortMessageHtmlLink":"Remove the cancellation token from the calculation of InProgressState…"}},{"before":"ad4f67194b148ef1c775b1bd873f779c26ed11c6","after":"1a05787e218677bce5ada3a0bf371e20efcda25c","ref":"refs/heads/WithDoNotCreateCreationPolicy_NoCancellationToken","pushedAt":"2024-09-06T12:51:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ToddGrun","name":"Todd Grunke","path":"/ToddGrun","primaryAvatarUrl":"https://github.com/avatars/u/6785178?s=80&v=4"},"commit":{"message":"better variable name","shortMessageHtmlLink":"better variable name"}},{"before":"8f8e0cdfb2fed032fd791a5d7224e23c9744753f","after":"ad4f67194b148ef1c775b1bd873f779c26ed11c6","ref":"refs/heads/WithDoNotCreateCreationPolicy_NoCancellationToken","pushedAt":"2024-09-06T12:44:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ToddGrun","name":"Todd Grunke","path":"/ToddGrun","primaryAvatarUrl":"https://github.com/avatars/u/6785178?s=80&v=4"},"commit":{"message":"switch to CancellableLazy","shortMessageHtmlLink":"switch to CancellableLazy"}},{"before":null,"after":"8f8e0cdfb2fed032fd791a5d7224e23c9744753f","ref":"refs/heads/WithDoNotCreateCreationPolicy_NoCancellationToken","pushedAt":"2024-09-05T16:59:17.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ToddGrun","name":"Todd Grunke","path":"/ToddGrun","primaryAvatarUrl":"https://github.com/avatars/u/6785178?s=80&v=4"},"commit":{"message":"Remove the cancellation token from the calculation of InProgressState.LazyStaleCompilationWithGeneratedDocuments\n\nThis will hopefully address multiple recent feedback tickets around Go To Definition occasionally failing. The umbrella pri 0 feedback ticket is https://developercommunity.visualstudio.com/t/Go-to-definition-doesnt-work/10729503\n\nI was able to reproduce this by following the repro outlined by Garry in the feedback ticket, using the \"Code Search\" window and doing go to definition multiple times.\n\nThe issue here is that RegularCompilationTracker.FinalizeCompilationWorkerAsync tries to get the value from the Lazy inProgressState.LazyStaleCompilationWithGeneratedDocuments. This lazy holds onto an action that uses a CancellationToken that has already been cancelled, whereas the CancellationToken used by FinalizeCompilationWorkerAsync has not been cancelled. When the action for the lazy is performed, the corresponding OperationCanceledException ends up escaping out of FinalizeCompilationWorker due to the FatalError.ReportAndPropagateUnlessCanceled exception clause failing due to the cancellation token passed into FinalizeCompilationWorkerAsync not being in a cancelled state.\n\nThe offending Lazy is constructed by RegularCompilationTracker.WithDoNotCreateCreationPolicy's call to the InProgressState ctor. Instead of passing a closure capturing a cancellation token, I've changed the code to instead only add syntax trees to the compilation that are already realized. I'm not 100% confident that this is sufficient, and if not, another alternative I can think of would be to change this to an AsyncLazy.","shortMessageHtmlLink":"Remove the cancellation token from the calculation of InProgressState…"}},{"before":null,"after":"a4f73e449e54432a669092f32ed2a289a29a87dc","ref":"refs/heads/AddNFWTrackingToSolutionRemoveProjectReference","pushedAt":"2024-08-31T03:16:55.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ToddGrun","name":"Todd Grunke","path":"/ToddGrun","primaryAvatarUrl":"https://github.com/avatars/u/6785178?s=80&v=4"},"commit":{"message":"Add NFW tracking to Solution.RemoveProjectReference\n\nWill help find underlying issue for https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2136005\n\nCPS has a system to catch exceptions from code they call into and have created this bug with a callstack and essentially no additional information about the exception being thrown. The hope here is that our reporting system will give us more actionable data.","shortMessageHtmlLink":"Add NFW tracking to Solution.RemoveProjectReference"}},{"before":"97b40388206ceb60551303668a8681cb5f43bb76","after":"30f47eeda4d27e94bcc407647d76333beafc5f0a","ref":"refs/heads/TextLinesCollection_Allocations","pushedAt":"2024-08-21T18:05:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ToddGrun","name":"Todd Grunke","path":"/ToddGrun","primaryAvatarUrl":"https://github.com/avatars/u/6785178?s=80&v=4"},"commit":{"message":"Update a comment and remove a condition that was preventing setting some data in the empty SubText.UnderlyingSpan case.","shortMessageHtmlLink":"Update a comment and remove a condition that was preventing setting s…"}},{"before":"8cab6a8a936ad1d110ee77a3b910b235d4af87de","after":"ed9cd8338e3fc71182dd7f65f1fa9409ef709018","ref":"refs/heads/CSharpSyntaxFactsArrayBuilderUsage","pushedAt":"2024-08-20T18:06:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ToddGrun","name":"Todd Grunke","path":"/ToddGrun","primaryAvatarUrl":"https://github.com/avatars/u/6785178?s=80&v=4"},"commit":{"message":"Remove method was using for testing","shortMessageHtmlLink":"Remove method was using for testing"}},{"before":"31c6079c02dc9743b29f7398759e8038d3c597fd","after":"8cab6a8a936ad1d110ee77a3b910b235d4af87de","ref":"refs/heads/CSharpSyntaxFactsArrayBuilderUsage","pushedAt":"2024-08-20T18:03:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ToddGrun","name":"Todd Grunke","path":"/ToddGrun","primaryAvatarUrl":"https://github.com/avatars/u/6785178?s=80&v=4"},"commit":{"message":"add back using","shortMessageHtmlLink":"add back using"}},{"before":"86986e1953836ff4f97b8f9d1062dade97d8524c","after":"31c6079c02dc9743b29f7398759e8038d3c597fd","ref":"refs/heads/CSharpSyntaxFactsArrayBuilderUsage","pushedAt":"2024-08-20T18:00:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ToddGrun","name":"Todd Grunke","path":"/ToddGrun","primaryAvatarUrl":"https://github.com/avatars/u/6785178?s=80&v=4"},"commit":{"message":"Have (CSharp/VisualBasic)SyntaxFacts classes own the pool. *Hopefully*, this will finally get the allocation reductions, as having each caller own what pool they use was giving me grief.","shortMessageHtmlLink":"Have (CSharp/VisualBasic)SyntaxFacts classes own the pool. *Hopefully…"}},{"before":"1c559959e2b25fea517c6f89d0c363698421865d","after":"e07c895486e693cf20362649f807bdaeddb7d64a","ref":"refs/heads/dev/toddgrun/release/dev17.10-no-change","pushedAt":"2024-08-20T17:25:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ToddGrun","name":"Todd Grunke","path":"/ToddGrun","primaryAvatarUrl":"https://github.com/avatars/u/6785178?s=80&v=4"},"commit":{"message":"dummy commit","shortMessageHtmlLink":"dummy commit"}},{"before":null,"after":"1c559959e2b25fea517c6f89d0c363698421865d","ref":"refs/heads/dev/toddgrun/release/dev17.10-no-change","pushedAt":"2024-08-20T17:22:07.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ToddGrun","name":"Todd Grunke","path":"/ToddGrun","primaryAvatarUrl":"https://github.com/avatars/u/6785178?s=80&v=4"},"commit":{"message":"Merge pull request #74477 from dotnet/dev/arkalyan/missingcollapse17.10\n\n17.10 : Also checking line end when block structure is filtered","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2423246341\" data-permission-text=\"Title is private\" data-url=\"https://github.com/dotnet/roslyn/issues/74477\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/dotnet/roslyn/pull/74477/hovercard\" href=\"https://github.com/dotnet/roslyn/pull/74477\">dotnet#74477</a> from dotnet/dev/arkalyan/missingcolla…"}},{"before":null,"after":"9e0115bcb185e9de2b684c08ff37b4a9991f2b0d","ref":"refs/heads/8-20-temp","pushedAt":"2024-08-20T16:18:55.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ToddGrun","name":"Todd Grunke","path":"/ToddGrun","primaryAvatarUrl":"https://github.com/avatars/u/6785178?s=80&v=4"},"commit":{"message":"temp commit","shortMessageHtmlLink":"temp commit"}},{"before":"2dae6b9e1e1a9435293f51d4eb1c1ac4503ddd3a","after":"97b40388206ceb60551303668a8681cb5f43bb76","ref":"refs/heads/TextLinesCollection_Allocations","pushedAt":"2024-08-19T18:34:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ToddGrun","name":"Todd Grunke","path":"/ToddGrun","primaryAvatarUrl":"https://github.com/avatars/u/6785178?s=80&v=4"},"commit":{"message":"Comment","shortMessageHtmlLink":"Comment"}},{"before":"94c3a55254a07fec4c913cd35b12d7133bf4226b","after":"86986e1953836ff4f97b8f9d1062dade97d8524c","ref":"refs/heads/CSharpSyntaxFactsArrayBuilderUsage","pushedAt":"2024-08-19T17:28:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ToddGrun","name":"Todd Grunke","path":"/ToddGrun","primaryAvatarUrl":"https://github.com/avatars/u/6785178?s=80&v=4"},"commit":{"message":"Add explicit scope to using stmts to reduce pool contention.","shortMessageHtmlLink":"Add explicit scope to using stmts to reduce pool contention."}},{"before":"a35b8c17a7a21a4eeca6944d8380565bf5c75601","after":"94c3a55254a07fec4c913cd35b12d7133bf4226b","ref":"refs/heads/CSharpSyntaxFactsArrayBuilderUsage","pushedAt":"2024-08-19T16:54:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ToddGrun","name":"Todd Grunke","path":"/ToddGrun","primaryAvatarUrl":"https://github.com/avatars/u/6785178?s=80&v=4"},"commit":{"message":"Use arrays directly instead of ArrayBuilder in certain situations","shortMessageHtmlLink":"Use arrays directly instead of ArrayBuilder in certain situations"}},{"before":null,"after":"a35b8c17a7a21a4eeca6944d8380565bf5c75601","ref":"refs/heads/CSharpSyntaxFactsArrayBuilderUsage","pushedAt":"2024-08-16T17:44:29.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ToddGrun","name":"Todd Grunke","path":"/ToddGrun","primaryAvatarUrl":"https://github.com/avatars/u/6785178?s=80&v=4"},"commit":{"message":"Reduce usage in CSharpSyntaxFacts.AppendMembers (again)\n\nA recent change(https://github.com/dotnet/roslyn/pull/74596) modified this code to take in an ArrayBuilder to allow callers to easily use pooled arrays. However, the size of the data populated into those arrays commonly exceeds the ArrayBuilder reuse threshold, those reducing the allocation benefit realized in those codepaths.\n\nThis PR changes the callers to instead use a pooled list, thus avoiding the threshold issue. Current scrolling speedometer results for the typing scenario still show this as allocating around 35 MB (which was about 3.5% at the time of the earlier PR). My hope is that this PR will get rid of nearly all those allocations this time.","shortMessageHtmlLink":"Reduce usage in CSharpSyntaxFacts.AppendMembers (again)"}},{"before":"0522300d9dddc094a4d058049b49f50ab404d500","after":"2dae6b9e1e1a9435293f51d4eb1c1ac4503ddd3a","ref":"refs/heads/TextLinesCollection_Allocations","pushedAt":"2024-08-16T14:21:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ToddGrun","name":"Todd Grunke","path":"/ToddGrun","primaryAvatarUrl":"https://github.com/avatars/u/6785178?s=80&v=4"},"commit":{"message":"Simplification in CompositeText's handling of split \\r\\n. Instead of handling in two different locations, just handle it in a single location up front.","shortMessageHtmlLink":"Simplification in CompositeText's handling of split \\r\\n. Instead of …"}},{"before":null,"after":"9dbfb18a891f5f16f9da1a7c5eb22556b64c2da4","ref":"refs/heads/TextLinesCollection_Allocations-syntaxfacts","pushedAt":"2024-08-16T13:18:49.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ToddGrun","name":"Todd Grunke","path":"/ToddGrun","primaryAvatarUrl":"https://github.com/avatars/u/6785178?s=80&v=4"},"commit":{"message":"temp stuff","shortMessageHtmlLink":"temp stuff"}},{"before":"a40219871f35e3a4f790243cdc3f46a77a3d1a5d","after":"0522300d9dddc094a4d058049b49f50ab404d500","ref":"refs/heads/TextLinesCollection_Allocations","pushedAt":"2024-08-15T19:25:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ToddGrun","name":"Todd Grunke","path":"/ToddGrun","primaryAvatarUrl":"https://github.com/avatars/u/6785178?s=80&v=4"},"commit":{"message":"Missed one requested assert","shortMessageHtmlLink":"Missed one requested assert"}},{"before":"7feb45105c68970e396e2f00da094865aae46531","after":"a40219871f35e3a4f790243cdc3f46a77a3d1a5d","ref":"refs/heads/TextLinesCollection_Allocations","pushedAt":"2024-08-15T19:22:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ToddGrun","name":"Todd Grunke","path":"/ToddGrun","primaryAvatarUrl":"https://github.com/avatars/u/6785178?s=80&v=4"},"commit":{"message":"a couple more suggestions by Cyrus","shortMessageHtmlLink":"a couple more suggestions by Cyrus"}},{"before":"41397b8452366040333d0b0be15f3300007ec1d6","after":"7feb45105c68970e396e2f00da094865aae46531","ref":"refs/heads/TextLinesCollection_Allocations","pushedAt":"2024-08-14T23:51:54.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ToddGrun","name":"Todd Grunke","path":"/ToddGrun","primaryAvatarUrl":"https://github.com/avatars/u/6785178?s=80&v=4"},"commit":{"message":"Lots of good cleanup per Cyrus's requests","shortMessageHtmlLink":"Lots of good cleanup per Cyrus's requests"}},{"before":"100549ae97e5baebd25181099965c4bf10d78cdb","after":"41397b8452366040333d0b0be15f3300007ec1d6","ref":"refs/heads/TextLinesCollection_Allocations","pushedAt":"2024-08-14T20:16:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ToddGrun","name":"Todd Grunke","path":"/ToddGrun","primaryAvatarUrl":"https://github.com/avatars/u/6785178?s=80&v=4"},"commit":{"message":"Add some comments, move some code around","shortMessageHtmlLink":"Add some comments, move some code around"}},{"before":null,"after":"1f75676fdc6fd46a56c14a98a1ae85da17e9c78d","ref":"refs/heads/dev/toddgrun/release/dev17.10-lightbulbfix","pushedAt":"2024-08-14T17:23:13.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ToddGrun","name":"Todd Grunke","path":"/ToddGrun","primaryAvatarUrl":"https://github.com/avatars/u/6785178?s=80&v=4"},"commit":{"message":"Fix scenario where lightbulbs weren't being displayed\n\nAddresses https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2087100\n\nThe recent change to remove solution crawler has apparently caused some regressions in lightbulb functionality and performance. This PR attempts to address at least one functional issue introduced as part of that change.\n\nPreviously, during solution load, solution crawler would cause the analyzer state sets to update via IncrementalAnalyzerProcessor.LowPriorityProcessor.ProcessProjectAsync's call to DiagnosticIncrementalAnalyzer.AnalyzeProjectAsync. Similarly, document updates would update the analyzer states the crawler's idle processing.\n\nInstead of trying to hook back in these calls, this PR instead changes the diagnostic analyzer service to no longer offer a TryGetDiagnosticsForSpanAsync, instead forcing users to use the GetDiagnosticsForSpanAsync instead. The only caller of TryGetDiagnosticsForSpanAsync was inside the CodeFixService, and it seems like that code should just go ahead and force correct results. Thus, there is no concept of a non-upToDate call into the diagnostic service.\n\nI'm going to separately investigate an issue with the StateManager's statesets not getting updated. I'm unsure why the code doesn't update the statesets upon calculation, but the fact that we are now recreating this on every lightbulb request is at least partly responsible for the recent lightbulb perf regression.","shortMessageHtmlLink":"Fix scenario where lightbulbs weren't being displayed"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xM1QxNToyNDoxOS4wMDAwMDBazwAAAAS1okeW","startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xM1QxNToyNDoxOS4wMDAwMDBazwAAAAS1okeW","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOC0xNFQxNzoyMzoxMy4wMDAwMDBazwAAAASagtGI"}},"title":"Activity · ToddGrun/roslyn"}