Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate PlateauProvider to BlockArea #27

Open
skaldarnar opened this issue Feb 6, 2021 · 1 comment
Open

Migrate PlateauProvider to BlockArea #27

skaldarnar opened this issue Feb 6, 2021 · 1 comment
Labels
Good First Issue Good for learners that are new to Terasology Size: S Small effort likely only affecting a single area and requiring little to no research Topic: WorldGen Requests, Issues and Changes related to facets, rasterizers, etc. Type: Refactoring Request for or implementation of pure and automatic refactorings, e.g. renaming, to improve clarity

Comments

@skaldarnar
Copy link
Contributor

See #25 (comment)

Currently, PlateauProvider uses a Rectanglei to handle an area. This should rather be a BlockArea, but we don't have feature parity between rectangle and area yet. In particular, BlockArea#distance[Squared](Vector3i point) does not exist yet.

This requires addition to BlockArea (and BlockRegion for consistency) in MovingBlocks/Terasology.
@shadowasphodel2919 shadowasphodel2919 mentioned this issue Apr 10, 2021
Merged
@jdrueckert
Copy link
Member

BlockArea#distance[Squared](Vector3i point) was successfully added in MovingBlocks/Terasology#4621

@jdrueckert jdrueckert added Good First Issue Good for learners that are new to Terasology Size: S Small effort likely only affecting a single area and requiring little to no research Topic: WorldGen Requests, Issues and Changes related to facets, rasterizers, etc. Type: Refactoring Request for or implementation of pure and automatic refactorings, e.g. renaming, to improve clarity labels May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Good for learners that are new to Terasology Size: S Small effort likely only affecting a single area and requiring little to no research Topic: WorldGen Requests, Issues and Changes related to facets, rasterizers, etc. Type: Refactoring Request for or implementation of pure and automatic refactorings, e.g. renaming, to improve clarity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@skaldarnar @jdrueckert