{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":1430051,"defaultBranch":"main","name":"typo3","ownerLogin":"TYPO3","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2011-03-02T10:02:23.000Z","ownerAvatar":"https://github.com/avatars/u/88698?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1723728230.0","currentOid":""},"activityList":{"items":[{"before":"dd58111bcbd856c3db38728331c54742e8cb4eb9","after":"85f7b74c2150e7e7c93d75a94d13e97536340cdb","ref":"refs/heads/main","pushedAt":"2024-08-22T06:43:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"reviewtypo3org","name":"Replication from review.typo3.org and git.typo3.org","path":"/reviewtypo3org","primaryAvatarUrl":"https://github.com/avatars/u/5028725?s=80&v=4"},"commit":{"message":"[BUGFIX] Respect correct max value when clamping progress bar value\n\nIn early development, the max value of a progress bar was limited to\nbeing `100`, which changed later on. This was not respected when\nclamping the actual value, the value was limited to being `100`.\n\nThis commit fixes the issue by taking the actual `max` value into\naccount.\n\nResolves: #104685\nReleases: main\nChange-Id: I20ebeb217990ed59eada397d312ceb1d937a3296\nReviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85713\nReviewed-by: Stefan Bürk \nReviewed-by: Andreas Kienast \nTested-by: core-ci \nReviewed-by: Anja Leichsenring \nTested-by: Anja Leichsenring \nTested-by: Stefan Bürk \nTested-by: Andreas Kienast ","shortMessageHtmlLink":"[BUGFIX] Respect correct max value when clamping progress bar value"}},{"before":"4cb94e383790ca89ff95335bea117d377cd413f7","after":"11ecb92ce1caebed98324a10ea5604a6ddadbe59","ref":"refs/heads/12.4","pushedAt":"2024-08-21T18:34:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"reviewtypo3org","name":"Replication from review.typo3.org and git.typo3.org","path":"/reviewtypo3org","primaryAvatarUrl":"https://github.com/avatars/u/5028725?s=80&v=4"},"commit":{"message":"[BUGFIX] Make Fluid DebuggerUtility css more safe against custom css\n\nFix not cklickable `+` sign for the nested properties in debugger\ntree in frontend.\nThe css selector for input fields of type checkbox are not strong enough\nif the website css defines own css rules and select checkboxes with\n\ninput[type=\"checkbox\"]\n\nthe selector in DebuggerUtility loses and properties are overriden.\nHeight, width, z-index and other properties were used to hide the\ndefault appearance of checkboxes and make those form elements looking\nnice. Therefore, DebuggerUtilitys selector should be a bit more\nstronger.\n\nResolves: #104681\nReleases: main, 12.4\nChange-Id: Id6964e0dbf19b83318f1e5de5f3763c6be6652a0\nReviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85712\nTested-by: Christian Kuhn \nReviewed-by: Christian Kuhn \nTested-by: core-ci ","shortMessageHtmlLink":"[BUGFIX] Make Fluid DebuggerUtility css more safe against custom css"}},{"before":"e222202b83fc9a2fd47e6401dfae79eee3716573","after":"dd58111bcbd856c3db38728331c54742e8cb4eb9","ref":"refs/heads/main","pushedAt":"2024-08-21T18:34:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"reviewtypo3org","name":"Replication from review.typo3.org and git.typo3.org","path":"/reviewtypo3org","primaryAvatarUrl":"https://github.com/avatars/u/5028725?s=80&v=4"},"commit":{"message":"[BUGFIX] Make Fluid DebuggerUtility css more safe against custom css\n\nFix not cklickable `+` sign for the nested properties in debugger\ntree in frontend.\nThe css selector for input fields of type checkbox are not strong enough\nif the website css defines own css rules and select checkboxes with\n\ninput[type=\"checkbox\"]\n\nthe selector in DebuggerUtility loses and properties are overriden.\nHeight, width, z-index and other properties were used to hide the\ndefault appearance of checkboxes and make those form elements looking\nnice. Therefore, DebuggerUtilitys selector should be a bit more\nstronger.\n\nResolves: #104681\nReleases: main, 12.4\nChange-Id: Id6964e0dbf19b83318f1e5de5f3763c6be6652a0\nReviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85710\nTested-by: Christian Kuhn \nReviewed-by: Anja Leichsenring \nReviewed-by: Christian Kuhn \nTested-by: core-ci \nTested-by: Anja Leichsenring \nReviewed-by: Garvin Hicking \nTested-by: Garvin Hicking ","shortMessageHtmlLink":"[BUGFIX] Make Fluid DebuggerUtility css more safe against custom css"}},{"before":"c8db5b5cbb16d9635c8bfb971077580f363e264f","after":"4cb94e383790ca89ff95335bea117d377cd413f7","ref":"refs/heads/12.4","pushedAt":"2024-08-21T18:20:19.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"reviewtypo3org","name":"Replication from review.typo3.org and git.typo3.org","path":"/reviewtypo3org","primaryAvatarUrl":"https://github.com/avatars/u/5028725?s=80&v=4"},"commit":{"message":"[BUGFIX] Properly log renaming of resources\n\nRenaming resources via the ResourceController,\ncalled via AJAX, does now also properly log\nthe performed action to be consistent with\nthe use of the ExtendedFileUtiltiy.\n\nResolves: #104569\nReleases: main, 12.4\nChange-Id: Icc2a5effcfa06269c2ad2f96cfa844206232ac60\nReviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85711\nTested-by: core-ci \nReviewed-by: Christian Kuhn \nTested-by: Christian Kuhn ","shortMessageHtmlLink":"[BUGFIX] Properly log renaming of resources"}},{"before":"caceca0c5a889910de1f16d4421844c8582a52ed","after":"e222202b83fc9a2fd47e6401dfae79eee3716573","ref":"refs/heads/main","pushedAt":"2024-08-21T18:20:19.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"reviewtypo3org","name":"Replication from review.typo3.org and git.typo3.org","path":"/reviewtypo3org","primaryAvatarUrl":"https://github.com/avatars/u/5028725?s=80&v=4"},"commit":{"message":"[BUGFIX] Properly log renaming of resources\n\nRenaming resources via the ResourceController,\ncalled via AJAX, does now also properly log\nthe performed action to be consistent with\nthe use of the ExtendedFileUtiltiy.\n\nResolves: #104569\nReleases: main, 12.4\nChange-Id: Icc2a5effcfa06269c2ad2f96cfa844206232ac60\nReviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85696\nTested-by: Anja Leichsenring \nReviewed-by: Anja Leichsenring \nTested-by: Christian Kuhn \nReviewed-by: Garvin Hicking \nTested-by: Garvin Hicking \nTested-by: core-ci \nReviewed-by: Christian Kuhn ","shortMessageHtmlLink":"[BUGFIX] Properly log renaming of resources"}},{"before":"b8978819603070b32084288d104d4c789422d42b","after":"caceca0c5a889910de1f16d4421844c8582a52ed","ref":"refs/heads/main","pushedAt":"2024-08-21T17:45:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"reviewtypo3org","name":"Replication from review.typo3.org and git.typo3.org","path":"/reviewtypo3org","primaryAvatarUrl":"https://github.com/avatars/u/5028725?s=80&v=4"},"commit":{"message":"[TASK] Use fluid attribute for Request handling\n\next:fluid RenderingContext is in the bad habit of extending\nfluid standalone RenderingContext with the two methods\nsetRequest() and getRequest() that are not part of fluid\nstandalone RenderingContextInterface.\n\nThis is ugly with type hinting and can't be changed in a\ngood way due to liskov collisions on method signatures in\nview helpers.\n\nFluid standalone also does not want to add these methods\nitself since it - as a view - wants to avoid dependencies\nto PSR-7.\n\nFluid standalone instead added setAttribute(), hasAttribute()\nand getAttribute() to RenderingContextInterface. This allows\nadding \"arbitrary\" objects.\n\nThe patch makes use of this: On the setter side, the\nRenderingContextFactory->create() is extended to accept\nthe request and set it as attribute, on the has/getter side\nall consumers are adapted.\n\nThis deprecates setRequest() and getRequest(), which are\nchanged to transparently work with the attribute instead.\n\nResolves: #104684\nReleases: main\nChange-Id: Id096073765c00e06e0437539f963f59a69e3fba0\nReviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85708\nTested-by: Garvin Hicking \nReviewed-by: Garvin Hicking \nTested-by: Christian Kuhn \nReviewed-by: Anja Leichsenring \nReviewed-by: Christian Kuhn \nTested-by: Anja Leichsenring ","shortMessageHtmlLink":"[TASK] Use fluid attribute for Request handling"}},{"before":"bf4ddd2b886486da13016ff69012d4535cd20a8f","after":"b8978819603070b32084288d104d4c789422d42b","ref":"refs/heads/main","pushedAt":"2024-08-21T09:21:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"reviewtypo3org","name":"Replication from review.typo3.org and git.typo3.org","path":"/reviewtypo3org","primaryAvatarUrl":"https://github.com/avatars/u/5028725?s=80&v=4"},"commit":{"message":"[TASK] Reduce TYPO3_REQUEST in extbase functional tests\n\nVarious ext:extbase functional tests set\n$GLOBALS['TYPO3_REQUEST']. The extbase\ncodebase still has various places that\naccess the global.\n\nWe can still reduce some usages in tests which\nare obsolete meanwhile, or can be improved by\nsetting the request on ConfigurationManager\ninstead, which is one of the main callers to\nthe $GLOBALS['TYPO3_REQUEST'] fallback in tests.\n\nResolves: #104677\nRelated: #104675\nReleases: main\nChange-Id: I8672cad869e64545c482664e5d995bc1ef02bd64\nReviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85706\nTested-by: Christian Kuhn \nTested-by: core-ci \nTested-by: Simon Praetorius \nReviewed-by: Christian Kuhn \nReviewed-by: Simon Praetorius \nTested-by: Oliver Bartsch \nReviewed-by: Oliver Bartsch ","shortMessageHtmlLink":"[TASK] Reduce TYPO3_REQUEST in extbase functional tests"}},{"before":"4a5b85159de6b39b4d8caf7d37e1e1357df27888","after":"bf4ddd2b886486da13016ff69012d4535cd20a8f","ref":"refs/heads/main","pushedAt":"2024-08-21T09:12:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"reviewtypo3org","name":"Replication from review.typo3.org and git.typo3.org","path":"/reviewtypo3org","primaryAvatarUrl":"https://github.com/avatars/u/5028725?s=80&v=4"},"commit":{"message":"[TASK] Make form styling context aware\n\nWe are dropping the Bootstrap CSS definitions for\nall form stylings to have more control about the\nstyling of the form elements. From now on we are\nshipping custom css adapted to our needs. The new\nform element styling is context aware and adapts\nto light and dark color schemes.\n\nResolves: #104676\nReleases: main\nChange-Id: I0da5017c961e9712c027f09a34f4cf91a7b11a45\nReviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83047\nTested-by: core-ci \nTested-by: Andreas Kienast \nReviewed-by: Benjamin Franzke \nTested-by: Benjamin Franzke \nReviewed-by: Andreas Kienast ","shortMessageHtmlLink":"[TASK] Make form styling context aware"}},{"before":"b5a111e4112f44ef133d8ea5a0a4f10b6860e377","after":"c8db5b5cbb16d9635c8bfb971077580f363e264f","ref":"refs/heads/12.4","pushedAt":"2024-08-20T22:07:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"reviewtypo3org","name":"Replication from review.typo3.org and git.typo3.org","path":"/reviewtypo3org","primaryAvatarUrl":"https://github.com/avatars/u/5028725?s=80&v=4"},"commit":{"message":"[BUGFIX] Explicitly set icon title in record list\n\nThere might be the case that the same flag\nicon is used for different languages. Due\nto iconFactory using a cache for generated\nicons, record list needs to set the title\nexplicitly to prevent using a wrong title\non reusing the flag icons.\n\nResolves: #104663\nReleases: main, 12.4\nChange-Id: I1eea6a608f1ce243cc0437de39c5b5ca323f2be1\nReviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85704\nTested-by: Oliver Bartsch \nReviewed-by: Oliver Bartsch \nTested-by: core-ci ","shortMessageHtmlLink":"[BUGFIX] Explicitly set icon title in record list"}},{"before":"6b4c8521b54ee2dd56082dc519fd1e205089f3eb","after":"4a5b85159de6b39b4d8caf7d37e1e1357df27888","ref":"refs/heads/main","pushedAt":"2024-08-20T21:25:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"reviewtypo3org","name":"Replication from review.typo3.org and git.typo3.org","path":"/reviewtypo3org","primaryAvatarUrl":"https://github.com/avatars/u/5028725?s=80&v=4"},"commit":{"message":"[BUGFIX] Explicitly set icon title in record list\n\nThere might be the case that the same flag\nicon is used for different languages. Due\nto iconFactory using a cache for generated\nicons, record list needs to set the title\nexplicitly to prevent using a wrong title\non reusing the flag icons.\n\nResolves: #104663\nReleases: main, 12.4\nChange-Id: I1eea6a608f1ce243cc0437de39c5b5ca323f2be1\nReviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85693\nReviewed-by: Andreas Kienast \nReviewed-by: Oliver Bartsch \nTested-by: Andreas Kienast \nReviewed-by: Garvin Hicking \nTested-by: Oliver Bartsch \nTested-by: core-ci \nTested-by: Garvin Hicking ","shortMessageHtmlLink":"[BUGFIX] Explicitly set icon title in record list"}},{"before":"2ceaa1676fbc2283323b782735902d44f83347d1","after":"6b4c8521b54ee2dd56082dc519fd1e205089f3eb","ref":"refs/heads/main","pushedAt":"2024-08-20T20:51:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"reviewtypo3org","name":"Replication from review.typo3.org and git.typo3.org","path":"/reviewtypo3org","primaryAvatarUrl":"https://github.com/avatars/u/5028725?s=80&v=4"},"commit":{"message":"[TASK] Avoid TYPO3_REQUEST in fluid functional tests\n\nVarious ext:fluid functional tests set\n$GLOBALS['TYPO3_REQUEST']. There are three\nscenarious fixed with this change:\n\n* A VH uses ContentObjectRenderer that is\n fetched from request attribute\n 'currentContentObject'. If the request\n has not been set up correctly, it falls\n back to globals. Set those properly.\n* Setting $GLOBALS['TYPO3_REQUEST'] is\n not needed at all.\n* The VH triggers extbase request dependent\n ConfigurationManager, which is not set\n up properly. Set up those.\n\nResolves: #104675\nReleases: main\nChange-Id: I9155de89aa2799710f3453977473c58e8382fa7b\nReviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85701\nReviewed-by: Christian Kuhn \nReviewed-by: Simon Praetorius \nReviewed-by: Stefan Bürk \nTested-by: Simon Praetorius \nTested-by: core-ci \nTested-by: Stefan Bürk \nTested-by: Christian Kuhn ","shortMessageHtmlLink":"[TASK] Avoid TYPO3_REQUEST in fluid functional tests"}},{"before":"edd438f9514fd764100918cc601c9392a51ed2c9","after":"2ceaa1676fbc2283323b782735902d44f83347d1","ref":"refs/heads/main","pushedAt":"2024-08-20T20:20:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"reviewtypo3org","name":"Replication from review.typo3.org and git.typo3.org","path":"/reviewtypo3org","primaryAvatarUrl":"https://github.com/avatars/u/5028725?s=80&v=4"},"commit":{"message":"[TASK] Avoid globals COR TYPO3_REQUEST in typolink VHs\n\nView helpers link.typolink and uri.typolink fail to\nset the given request on ContentObjectRenderer, so\nit falls back to $GLOBALS['TYPO3_REQUEST']. The patch\nsets the request (if given), and adapts the tests to\nrely on it, which avoid setting the global.\n\nResolves: #104674\nReleases: main\nChange-Id: Iac5d28eac3adce5632e70794f38956c244545509\nReviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85702\nTested-by: Stefan Bürk \nTested-by: Christian Kuhn \nReviewed-by: Stefan Bürk \nReviewed-by: Simon Praetorius \nTested-by: Simon Praetorius \nReviewed-by: Christian Kuhn \nTested-by: core-ci ","shortMessageHtmlLink":"[TASK] Avoid globals COR TYPO3_REQUEST in typolink VHs"}},{"before":"ef3747b970fef96b19f2d4ea901f64881aadc8e0","after":"edd438f9514fd764100918cc601c9392a51ed2c9","ref":"refs/heads/main","pushedAt":"2024-08-20T16:40:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"reviewtypo3org","name":"Replication from review.typo3.org and git.typo3.org","path":"/reviewtypo3org","primaryAvatarUrl":"https://github.com/avatars/u/5028725?s=80&v=4"},"commit":{"message":"[TASK] Decouple ext:form ConfigurationManager from extbase\n\nNext change in the \"Tame extbase ConfigurationManager\" series.\n\next:form comes with an add-on class of extbase\nConfigurationManager: It extends the class with an own feature\nto load the relevant YAML configuration from the extensions\nTypoScript. This is accompanied by an own interface.\n\nThis is not a great idea from a structural point of view:\nThe ext:form ConfigurationManager should be decoupled from\nextbase ConfigurationManager. It may decorate it, but should\nnot extend it. Or - even better - not have a dependency to\nextbase ConfigurationManager at all, but get the required\nextbase ConfigurationManager state hand over. The latter\noption is preferred since extbase ConfigurationManager\nis this evil injectable stateful singleton, that hides\nrequired state away. Turning this around in ext:form forces\nconsumers to hand over state directly, making the\ndependency to extbase ConfigurationManager state explicit\nin callers of ext:form ConfigurationManager.\n\nThe patch does this: ext:form ConfigurationManager no longer\nextends extbase ConfigurationManager, but is turned into a\nstandalone and stateless service with an own signature that\nactively receives needed state from consumers.\n\nResolves: #104670\nRelated: #104514\nReleases: main\nChange-Id: If6073eb50df788d45a7f4d73e95cbd2d54a8c5fe\nReviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85638\nTested-by: Stefan Bürk \nReviewed-by: Christian Kuhn \nReviewed-by: Simon Praetorius \nTested-by: Christian Kuhn \nReviewed-by: Stefan Bürk \nTested-by: Simon Praetorius \nTested-by: core-ci ","shortMessageHtmlLink":"[TASK] Decouple ext:form ConfigurationManager from extbase"}},{"before":"90d22e8a26ee1b661ed4b91b3f664db5b23251b1","after":"b5a111e4112f44ef133d8ea5a0a4f10b6860e377","ref":"refs/heads/12.4","pushedAt":"2024-08-20T14:32:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"reviewtypo3org","name":"Replication from review.typo3.org and git.typo3.org","path":"/reviewtypo3org","primaryAvatarUrl":"https://github.com/avatars/u/5028725?s=80&v=4"},"commit":{"message":"[BUGFIX] Fix undefined array key warnings in GifBuilder\n\nResolves: #104639\nReleases: main, 12.4, 11.5\nChange-Id: I74a0cd9e856283d26a382582cc5d6b8e99887cd4\nReviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85698\nTested-by: core-ci \nTested-by: Andreas Kienast \nReviewed-by: Andreas Kienast ","shortMessageHtmlLink":"[BUGFIX] Fix undefined array key warnings in GifBuilder"}},{"before":"5ecafdb710c4fd027c449aa813f2ca4a63f742a7","after":"ef3747b970fef96b19f2d4ea901f64881aadc8e0","ref":"refs/heads/main","pushedAt":"2024-08-20T14:32:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"reviewtypo3org","name":"Replication from review.typo3.org and git.typo3.org","path":"/reviewtypo3org","primaryAvatarUrl":"https://github.com/avatars/u/5028725?s=80&v=4"},"commit":{"message":"[BUGFIX] Fix undefined array key warnings in GifBuilder\n\nResolves: #104639\nReleases: main, 12.4, 11.5\nChange-Id: I74a0cd9e856283d26a382582cc5d6b8e99887cd4\nReviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85694\nTested-by: Andreas Kienast \nTested-by: Christian Kuhn \nReviewed-by: Christian Kuhn \nReviewed-by: Andreas Kienast \nTested-by: core-ci \nReviewed-by: Oliver Klee ","shortMessageHtmlLink":"[BUGFIX] Fix undefined array key warnings in GifBuilder"}},{"before":"10d2450119c37aa2379736d8a7c1390de9cee769","after":"f5e34cd11d753ff8b1d74f29aec52531d0ba0d7a","ref":"refs/heads/11.5","pushedAt":"2024-08-20T14:32:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"reviewtypo3org","name":"Replication from review.typo3.org and git.typo3.org","path":"/reviewtypo3org","primaryAvatarUrl":"https://github.com/avatars/u/5028725?s=80&v=4"},"commit":{"message":"[BUGFIX] Fix undefined array key warnings in GifBuilder\n\nResolves: #104639\nReleases: main, 12.4, 11.5\nChange-Id: I74a0cd9e856283d26a382582cc5d6b8e99887cd4\nReviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85699\nTested-by: core-ci \nReviewed-by: Andreas Kienast \nTested-by: Andreas Kienast ","shortMessageHtmlLink":"[BUGFIX] Fix undefined array key warnings in GifBuilder"}},{"before":"e4cab4b682a38dd15248abba3394535f192aac16","after":"5ecafdb710c4fd027c449aa813f2ca4a63f742a7","ref":"refs/heads/main","pushedAt":"2024-08-20T09:02:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"reviewtypo3org","name":"Replication from review.typo3.org and git.typo3.org","path":"/reviewtypo3org","primaryAvatarUrl":"https://github.com/avatars/u/5028725?s=80&v=4"},"commit":{"message":"[TASK] Do not use ConfigurationManager in FormPersistenceManager\n\nThe FormPersistenceManager is a central class of ext:form\nthat takes care of .form.yaml writing and loading. This\nincludes overloading with form specific TypoScript settings\nand sanitation of storage locations based on module.tx_form\nTypoScript.\n\nSince ext:form is designed as an extbase extension,\nFormPersistenceManager relies on extbase ConfigurationManager\nto retrieve TypoScript. The ext:form internal own variant\nof extbase ConfigurationManager has this dependency as well.\n\nThis wouldn't be a huge problem if FormPersistenceManager\nis only used from within the extbase bootstrapped extension\ncontext only. FormPersistenceManager however is used\n'out-of-context' in three places: It is used within the\nBE FormEngine related flex form data structure handling\nhook, within the BE page module related content element\npreview rendering, and by the formvh:render view helper.\n\nThese three places do not have an extbase context, so extbase,\nand especially the extbase related stateful injectable singleton\nConfigurationManager, has not been configured at these points.\nExtbase ConfigurationManager, and in turn the ext:form extended\nvariant as well, have a dependency to the request to work\nproperly and thus rely on the request being set up correctly.\n\nTo deal with this, FormPersistenceManager configures extbase\nConfigurationManager within __construct() by handing over the\nrequest from $GLOBALS['TYPO3_REQUEST'].\n\nThis is bad for a series of reasons, one being obviously the\naccess to $GLOBALS['TYPO3_REQUEST'] within __construct() in\nthe first place. Also, FormPersistenceManager is quite often\nused *within* properly configured extbase context as well,\nfor instance from within the extbase based ext:form\ncontrollers, so FormPersistenceManager then reconfigures\nextbase ConfigurationManager with the (non-extbase) global\nrequest and thus messes up its state.\n\nThe problem is here that FormPersistenceManager does not and\ncan not know wether its used 'out-of-context'.\n\nTo deal with this, the patch removes use of ConfigurationManager\nto retrieve TypoScript within FormPersistenceManager, and forces\nconsumers to hand it over to those methods that need it. The\nidea is that only the callers know their context and can take\ncare of setting up ConfigurationManager as needed on their own.\n\nThis approach makes the dependency to the request object\nexplicit: Two of the three 'out-of-context' places are \"ok\" with\nthat: The BE page module preview rendering has the request\navailable, the formvh:render view helper as well. The third\none will be harder to resolve: The flex form related data\nstructure handling has not been designed to have the request,\nthere may or may not be CLI situations in this low level handling\nwhere no request is available. This needs further analysis, the\npatch outlines various options for now.\n\nThe patch forces FormPersistenceManagerInterface to be adapted,\nwhich should not be a huge issue since the overall functionality\nis ext:form internal, and there shouldn't be extensions that\nuse it directly. The patch is thus *not* considered breaking\nand FormPersistenceManagerInterface is now declared @internal\nalong the way to reflect this.\n\nAlso, as usual when working in this area, the related tests\nreceive an overhaul to deal with the new signatures and\ninternal handling, and to be more easy to maintain.\n\nAlso, class ext:form ConfigurationService suffers from\nsimilar issues as outlined above and will probably need\na revamp as well. This one however is only used in\ncombination with FormPersistenceManager when used\n'out-of-context', so the changes for FormPersistenceManager\nrelax this situation as well. Still, and @todo is left in it.\n\nResolves: #104667\nRelated: #92408\nRelated: #102558\nReleases: main\nChange-Id: I555aa6445f1fad577253cf90065df540a5830bd7\nReviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85669\nReviewed-by: Anja Leichsenring \nReviewed-by: Christian Kuhn \nReviewed-by: Stefan Bürk \nTested-by: core-ci \nTested-by: Anja Leichsenring \nTested-by: Stefan Bürk \nTested-by: Christian Kuhn ","shortMessageHtmlLink":"[TASK] Do not use ConfigurationManager in FormPersistenceManager"}},{"before":"9c62ba6501c17d4094bcc1d35f6d72947aa9f44f","after":"90d22e8a26ee1b661ed4b91b3f664db5b23251b1","ref":"refs/heads/12.4","pushedAt":"2024-08-20T08:46:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"reviewtypo3org","name":"Replication from review.typo3.org and git.typo3.org","path":"/reviewtypo3org","primaryAvatarUrl":"https://github.com/avatars/u/5028725?s=80&v=4"},"commit":{"message":"[BUGFIX] Remove TCEforms leftovers leading to Exception\n\nTCEforms were removed with #97126 in v12.\nStill there was a usage within EditPopup leading to an Exception when\nediting a record with FlexForm via edit form control.\n\nResolves: #104658\nReleases: main, 12.4\nChange-Id: Ie7110367922a99ca088b416da4c11a025efcde00\nReviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85692\nTested-by: Christian Kuhn \nReviewed-by: Christian Kuhn \nTested-by: core-ci ","shortMessageHtmlLink":"[BUGFIX] Remove TCEforms leftovers leading to Exception"}},{"before":"e640fe3832ff7a9a887413865118eebd5ba875f3","after":"e4cab4b682a38dd15248abba3394535f192aac16","ref":"refs/heads/main","pushedAt":"2024-08-20T08:46:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"reviewtypo3org","name":"Replication from review.typo3.org and git.typo3.org","path":"/reviewtypo3org","primaryAvatarUrl":"https://github.com/avatars/u/5028725?s=80&v=4"},"commit":{"message":"[BUGFIX] Remove TCEforms leftovers leading to Exception\n\nTCEforms were removed with #97126 in v12.\nStill there was a usage within EditPopup leading to an Exception when\nediting a record with FlexForm via edit form control.\n\nResolves: #104658\nReleases: main, 12.4\nChange-Id: Ie7110367922a99ca088b416da4c11a025efcde00\nReviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85676\nReviewed-by: Christian Kuhn \nTested-by: core-ci \nTested-by: Garvin Hicking \nReviewed-by: Garvin Hicking \nTested-by: Christian Kuhn \nReviewed-by: Andreas Kienast ","shortMessageHtmlLink":"[BUGFIX] Remove TCEforms leftovers leading to Exception"}},{"before":"dddf99ae6aab5a6f19e749ee5b57ae76cadc150b","after":"e640fe3832ff7a9a887413865118eebd5ba875f3","ref":"refs/heads/main","pushedAt":"2024-08-20T08:20:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"reviewtypo3org","name":"Replication from review.typo3.org and git.typo3.org","path":"/reviewtypo3org","primaryAvatarUrl":"https://github.com/avatars/u/5028725?s=80&v=4"},"commit":{"message":"[DOCS] Add examples to PHPDoc of new data processors\n\nResolves: #104665\nRelated: #103783\nReleases: main\nChange-Id: I60bb7561f25a0c25068064890ee5deb474c183e4\nReviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85681\nReviewed-by: Jochen Roth \nReviewed-by: Christian Kuhn \nReviewed-by: Garvin Hicking \nReviewed-by: Oliver Bartsch \nTested-by: Oliver Bartsch \nTested-by: Garvin Hicking \nTested-by: core-ci \nTested-by: Christian Kuhn \nTested-by: Jochen Roth ","shortMessageHtmlLink":"[DOCS] Add examples to PHPDoc of new data processors"}},{"before":"2dc7bd4e4dbfca77401e4b91dd151061d0b60ae1","after":"dddf99ae6aab5a6f19e749ee5b57ae76cadc150b","ref":"refs/heads/main","pushedAt":"2024-08-20T07:29:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"reviewtypo3org","name":"Replication from review.typo3.org and git.typo3.org","path":"/reviewtypo3org","primaryAvatarUrl":"https://github.com/avatars/u/5028725?s=80&v=4"},"commit":{"message":"[BUGFIX] Use correct date format in EXT:styleguide date picker example\n\nThe date picker used in EXT:styleguide -> Components -> Form needs\nanother format to be functional again.\n\nResolves: #104660\nReleases: main\nChange-Id: Iec506bbdbb68d3f41c6e9c0fb5701fc5ba0522d3\nReviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85678\nTested-by: Garvin Hicking \nReviewed-by: Garvin Hicking \nReviewed-by: Oliver Bartsch \nTested-by: core-ci \nTested-by: Oliver Bartsch ","shortMessageHtmlLink":"[BUGFIX] Use correct date format in EXT:styleguide date picker example"}},{"before":"826f777f5f19a188b5e77570a750f86b275f2b66","after":"2dc7bd4e4dbfca77401e4b91dd151061d0b60ae1","ref":"refs/heads/main","pushedAt":"2024-08-19T15:30:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"reviewtypo3org","name":"Replication from review.typo3.org and git.typo3.org","path":"/reviewtypo3org","primaryAvatarUrl":"https://github.com/avatars/u/5028725?s=80&v=4"},"commit":{"message":"[DOCS] Document \"Enable recycler by default\"\n\nDocuments https://review.typo3.org/c/Packages/TYPO3.CMS/+/85472\n\nResolves: #104647\nReleases: main\nChange-Id: Ifb41959a20001664e39eadbd13d85cfbc153a783\nReviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85663\nTested-by: core-ci \nTested-by: Stefan Bürk \nReviewed-by: Chris Müller \nReviewed-by: Garvin Hicking \nTested-by: Chris Müller \nReviewed-by: Stefan Bürk \nTested-by: Garvin Hicking ","shortMessageHtmlLink":"[DOCS] Document \"Enable recycler by default\""}},{"before":"96472deee9ebfd7fd37c3ce7d1035ec6243cbdf3","after":"9c62ba6501c17d4094bcc1d35f6d72947aa9f44f","ref":"refs/heads/12.4","pushedAt":"2024-08-19T11:42:24.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"reviewtypo3org","name":"Replication from review.typo3.org and git.typo3.org","path":"/reviewtypo3org","primaryAvatarUrl":"https://github.com/avatars/u/5028725?s=80&v=4"},"commit":{"message":"[TASK] Enhance TYPO3\\CMS\\Core\\Type\\Map capabilities\n\nThis change introduces the following enhancements:\n\n* `Map::keys(): array` resolves all keys of a map\n* `Map::values(): array` resolves all values of a map\n* `Map::assign(?Map): void` incorporates entries of other map\n\nResolves: #104656\nReleases: main, 12.4\nChange-Id: Ifc358c83275128c52f8f195b06c1b36f54227f86\nReviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85679\nTested-by: core-ci \nReviewed-by: Oliver Hader \nTested-by: Oliver Hader ","shortMessageHtmlLink":"[TASK] Enhance TYPO3\\CMS\\Core\\Type\\Map capabilities"}},{"before":"04102c1cdc3a5b9db83b61315c28f7234c2d4e1f","after":"826f777f5f19a188b5e77570a750f86b275f2b66","ref":"refs/heads/main","pushedAt":"2024-08-19T11:42:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"reviewtypo3org","name":"Replication from review.typo3.org and git.typo3.org","path":"/reviewtypo3org","primaryAvatarUrl":"https://github.com/avatars/u/5028725?s=80&v=4"},"commit":{"message":"[TASK] Enhance TYPO3\\CMS\\Core\\Type\\Map capabilities\n\nThis change introduces the following enhancements:\n\n* `Map::keys(): array` resolves all keys of a map\n* `Map::values(): array` resolves all values of a map\n* `Map::assign(?Map): void` incorporates entries of other map\n\nResolves: #104656\nReleases: main, 12.4\nChange-Id: Ifc358c83275128c52f8f195b06c1b36f54227f86\nReviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85673\nReviewed-by: Oliver Hader \nTested-by: Stefan Bürk \nReviewed-by: Andreas Kienast \nTested-by: Andreas Kienast \nReviewed-by: Stefan Bürk \nTested-by: Oliver Hader \nTested-by: core-ci ","shortMessageHtmlLink":"[TASK] Enhance TYPO3\\CMS\\Core\\Type\\Map capabilities"}},{"before":"ee321f5a7a2e4339410c3f6c673308231094f762","after":"04102c1cdc3a5b9db83b61315c28f7234c2d4e1f","ref":"refs/heads/main","pushedAt":"2024-08-18T08:39:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"reviewtypo3org","name":"Replication from review.typo3.org and git.typo3.org","path":"/reviewtypo3org","primaryAvatarUrl":"https://github.com/avatars/u/5028725?s=80&v=4"},"commit":{"message":"[TASK] Improve detail and comparison views of \"Backend Users\" BE module\n\nThe backend module \"Backend Users\" lists all backend users and backend\nuser groups in the system.\n\nA detailed view can be called up for each backend user, which shows all\ncompiled rights and settings for the backend user. This view has been\nrevised to increase the UX and user-friendliness.\n\nThe backend module also offers the option of comparing individual\nbackend users or backend user groups with each other. These comparison\nviews have also been slightly adjusted to improve clarity.\n\nResolves: #104635\nReleases: main\nChange-Id: I2f118ea49783e99c2b174dd33a7d58847338e183\nReviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85543\nReviewed-by: Jasmina Ließmann \nTested-by: Guido Schmechel \nTested-by: Stefan Bürk \nReviewed-by: Stefan Bürk \nTested-by: Jasmina Ließmann \nTested-by: core-ci \nReviewed-by: Guido Schmechel ","shortMessageHtmlLink":"[TASK] Improve detail and comparison views of \"Backend Users\" BE module"}},{"before":"db8105fbed6caff46e30a836baf56e7ff4a93743","after":"ee321f5a7a2e4339410c3f6c673308231094f762","ref":"refs/heads/main","pushedAt":"2024-08-17T12:28:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"reviewtypo3org","name":"Replication from review.typo3.org and git.typo3.org","path":"/reviewtypo3org","primaryAvatarUrl":"https://github.com/avatars/u/5028725?s=80&v=4"},"commit":{"message":"[DOCS] Update EXT:felogin Configuration listing\n\nAs prepatch for https://forge.typo3.org/issues/104597\n\nOnly syntax changes and a changed headline. Layout will\nbe addressed via https://github.com/TYPO3-Documentation/render-guides/issues/707.\n\nResolves: #104644\nRelated: #104597\nReleases: main, 12.4\nChange-Id: Ibe9ee56d522c6eb1b337d38ed61bd004124fee6e\nReviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85661\nTested-by: Christian Kuhn \nReviewed-by: Christian Kuhn \nReviewed-by: Garvin Hicking \nTested-by: core-ci \nTested-by: Garvin Hicking ","shortMessageHtmlLink":"[DOCS] Update EXT:felogin Configuration listing"}},{"before":"15254c52d55745dea205aeed9a72c189a69e0795","after":"96472deee9ebfd7fd37c3ce7d1035ec6243cbdf3","ref":"refs/heads/12.4","pushedAt":"2024-08-17T12:28:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"reviewtypo3org","name":"Replication from review.typo3.org and git.typo3.org","path":"/reviewtypo3org","primaryAvatarUrl":"https://github.com/avatars/u/5028725?s=80&v=4"},"commit":{"message":"[DOCS] Update EXT:felogin Configuration listing\n\nAs prepatch for https://forge.typo3.org/issues/104597\n\nOnly syntax changes and a changed headline. Layout will\nbe addressed via https://github.com/TYPO3-Documentation/render-guides/issues/707.\n\nResolves: #104644\nRelated: #104597\nReleases: main, 12.4\nChange-Id: Ibe9ee56d522c6eb1b337d38ed61bd004124fee6e\nReviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85471\nTested-by: Garvin Hicking \nReviewed-by: Garvin Hicking \nTested-by: core-ci ","shortMessageHtmlLink":"[DOCS] Update EXT:felogin Configuration listing"}},{"before":"3f74fabf0a34ec98d67c66b521ee51853368a803","after":"db8105fbed6caff46e30a836baf56e7ff4a93743","ref":"refs/heads/main","pushedAt":"2024-08-17T10:59:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"reviewtypo3org","name":"Replication from review.typo3.org and git.typo3.org","path":"/reviewtypo3org","primaryAvatarUrl":"https://github.com/avatars/u/5028725?s=80&v=4"},"commit":{"message":"[DOCS] Document base64 attribute of f:uri.image\n\nReferences:\nhttps://github.com/TYPO3-Documentation/Changelog-To-Doc/issues/982\n\nReleases: main\nResolves: #104649\nRelated: #101391\nChange-Id: I525d6fe5172b5bab110882140137601e7d508a83\nReviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85665\nTested-by: Garvin Hicking \nReviewed-by: Garvin Hicking ","shortMessageHtmlLink":"[DOCS] Document base64 attribute of f:uri.image"}},{"before":"aaaba376b59be34fc97ff6308385b1b3cded3fe4","after":"3f74fabf0a34ec98d67c66b521ee51853368a803","ref":"refs/heads/main","pushedAt":"2024-08-17T10:57:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"reviewtypo3org","name":"Replication from review.typo3.org and git.typo3.org","path":"/reviewtypo3org","primaryAvatarUrl":"https://github.com/avatars/u/5028725?s=80&v=4"},"commit":{"message":"[DOCS] Document base64 attribute of f:image\n\nreferences:\nhttps://github.com/TYPO3-Documentation/Changelog-To-Doc/issues/982\n\nReleases: main\nResolves: #104648\nRelated: #101391\nChange-Id: I6182144b7f18486813fc8236d58e0c53921cd6b9\nReviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85664\nReviewed-by: Garvin Hicking \nTested-by: Garvin Hicking ","shortMessageHtmlLink":"[DOCS] Document base64 attribute of f:image"}},{"before":"84c96f31017fe28894f3a26ca4624658b7d8c84e","after":"aaaba376b59be34fc97ff6308385b1b3cded3fe4","ref":"refs/heads/main","pushedAt":"2024-08-17T10:55:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"reviewtypo3org","name":"Replication from review.typo3.org and git.typo3.org","path":"/reviewtypo3org","primaryAvatarUrl":"https://github.com/avatars/u/5028725?s=80&v=4"},"commit":{"message":"[DOCS] Document Introduce hotkeys to scheduler task editing\n\nDocumentation of https://review.typo3.org/c/Packages/TYPO3.CMS/+/83702\nhttps://github.com/TYPO3-Documentation/Changelog-To-Doc/issues/895\n\nResolves: #104650\nRelated: #103563\nReleases: main\nChange-Id: Iaf7603c0873bef2889b7380c3cf6c3aeedcf2c05\nReviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85666\nTested-by: Garvin Hicking \nReviewed-by: Garvin Hicking ","shortMessageHtmlLink":"[DOCS] Document Introduce hotkeys to scheduler task editing"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEoPKoTQA","startCursor":null,"endCursor":null}},"title":"Activity · TYPO3/typo3"}