From f651c0f77ff4e4baac3859f2aeeb5ab42e2d0e76 Mon Sep 17 00:00:00 2001 From: Grzegorz Sadowski Date: Tue, 9 Mar 2021 09:24:45 +0100 Subject: [PATCH] Check proper state during resolving order refunded state --- spec/StateResolver/OrderFullyRefundedStateResolverSpec.php | 6 +++--- src/StateResolver/OrderFullyRefundedStateResolver.php | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/spec/StateResolver/OrderFullyRefundedStateResolverSpec.php b/spec/StateResolver/OrderFullyRefundedStateResolverSpec.php index 2fbb833e..d4f8781f 100644 --- a/spec/StateResolver/OrderFullyRefundedStateResolverSpec.php +++ b/spec/StateResolver/OrderFullyRefundedStateResolverSpec.php @@ -41,7 +41,7 @@ function it_applies_refund_transition_on_order( ): void { $orderRepository->findOneByNumber('000222')->willReturn($order); $orderFullyRefundedTotalChecker->isOrderFullyRefunded($order)->willReturn(true); - $order->getState()->willReturn(OrderInterface::STATE_NEW); + $order->getPaymentState()->willReturn(OrderPaymentStates::STATE_PAID); $stateMachineFactory->get($order, OrderPaymentTransitions::GRAPH)->willReturn($stateMachine); $stateMachine->apply(OrderPaymentTransitions::TRANSITION_REFUND)->shouldBeCalled(); @@ -59,7 +59,7 @@ function it_does_nothing_if_order_state_is_fully_refunded( ): void { $orderRepository->findOneByNumber('000222')->willReturn($order); $orderFullyRefundedTotalChecker->isOrderFullyRefunded($order)->willReturn(true); - $order->getState()->willReturn(OrderPaymentStates::STATE_REFUNDED); + $order->getPaymentState()->willReturn(OrderPaymentStates::STATE_REFUNDED); $stateMachineFactory->get(Argument::any())->shouldNotBeCalled(); @@ -80,7 +80,7 @@ function it_does_nothing_if_order_is_not_fully_refunded( $this->resolve('000222'); } - function it_throws_exception_if_there_is_no_order_with_given_number(OrderRepositoryInterface $orderRepository): void + function it_throws_an_exception_if_there_is_no_order_with_given_number(OrderRepositoryInterface $orderRepository): void { $orderRepository->findOneByNumber('000222')->willReturn(null); diff --git a/src/StateResolver/OrderFullyRefundedStateResolver.php b/src/StateResolver/OrderFullyRefundedStateResolver.php index 18f6e6fa..40e3cece 100644 --- a/src/StateResolver/OrderFullyRefundedStateResolver.php +++ b/src/StateResolver/OrderFullyRefundedStateResolver.php @@ -47,7 +47,7 @@ public function resolve(string $orderNumber): void if ( !$this->orderFullyRefundedTotalChecker->isOrderFullyRefunded($order) || - OrderPaymentStates::STATE_REFUNDED === $order->getState() + OrderPaymentStates::STATE_REFUNDED === $order->getPaymentState() ) { return; }