Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elfinder.UA.Touch - wrong value on desktop #2499

Closed
pjetrucha opened this issue May 10, 2018 · 1 comment
Closed

elfinder.UA.Touch - wrong value on desktop #2499

pjetrucha opened this issue May 10, 2018 · 1 comment
Assignees

Comments

@pjetrucha
Copy link

In Firefox elfinder.UA.Touch returns true on dektop (Windows 10). Moreover Firefox dosn't support CSS zoom property which is used in this case and has fallback to -moz-transform: scale. In the end toolbar icons look like broken.

On Firefox:
firefox
On Chrome:
chrome

The condition for this property looks like this:
typeof window.ontouchstart != "undefined"
I think that this test is insufficient. ontouchstart is in window regardless of whether the touch screen hardware device is connected or not.

Maybe you should combain this check with Mobile test?

@nao-pon
Copy link
Member

nao-pon commented May 11, 2018

@pjetrucha Adjustment of CSS is necessary for Firefox. I will make that amendment.

Since UA.Touch is a flag as to whether it is a touch device or not, I think that there is no problem with current judgment.

Thanks! 👍

@nao-pon nao-pon self-assigned this May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants