Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: ImNodes pin style variables not working #163

Closed
brunopj1 opened this issue Mar 3, 2023 · 1 comment
Closed

Bug: ImNodes pin style variables not working #163

brunopj1 opened this issue Mar 3, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@brunopj1
Copy link
Contributor

brunopj1 commented Mar 3, 2023

Version

1.86.8

What happened?

I found a couple bugs with the ImNodes pin style variables.

The first problem is that pushing ImNodesStyleVar.PinCircleRadius or ImNodesStyleVar.PinQuadSideLength doesn't do anything. Instead, the size of every pin shape is changed by pushing ImNodesStyleVar.PinTriangleSideLength.

The second problem is that changing the pin size only affects "unfilled" pin shapes. ImNodesPinShape.CircleFilled, ImNodesPinShape.TriangleFilled and ImNodesPinShape.QuadFilled keep the default size.

Reproduction

I do this at the start of the program:

ImNodes.pushStyleVar(ImNodesStyleVar.PinCircleRadius, 100.0f);
ImNodes.pushStyleVar(ImNodesStyleVar.PinQuadSideLength, 100.0f);
ImNodes.pushStyleVar(ImNodesStyleVar.PinTriangleSideLength, 10.0f);

And I do this when rendering a pin:

ImNodes.beginInputAttribute(inputPinId, ImNodesPinShape.Circle);
ImGui.dummy(0.0f, pinOffset);
ImNodes.endInputAttribute();

ImNodes.beginOutputAttribute(outputPinId, ImNodesPinShape.CircleFilled);
ImGui.dummy(0.0f, pinOffset);
ImNodes.endOutputAttribute();

Relevant log output

No response

@brunopj1 brunopj1 added the bug Something isn't working label Mar 3, 2023
@SpaiR SpaiR added the api label Mar 9, 2023
@brunopj1
Copy link
Contributor Author

brunopj1 commented Mar 9, 2023

Fixed in #167

@brunopj1 brunopj1 closed this as completed Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants