-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matter Thermostat extend Air Quality Sensor #1479
Conversation
lualibs imported to thermostat Capabilities added to test profile; greater unit conversion inclusion do_configure logic updated to include aqs and ap + thermostat profiles do_configure logic updated to include aqs and ap + thermostat profiles
Allows for profiles to be created that use any combination of AQS, thermostat, and fan device types. Also adds a new profile that includes much of this extended functionality.
Duplicate profile check: Passed - no duplicate profiles detected. |
Minimum allowed coverage is Generated by 🐒 cobertura-action against cdf373c |
Channel deleted. |
Completed Testing: |
69c722e
to
520ee59
Compare
Tested with 52 and 53 lua libs and confirmed that AiDot Air Purifier will onboard and correctly switch to |
This is looking good, great work @hcarter-775 !! One last thing would be to add some unit tests. This change is mostly to onboarding, so I think this would be a good unit test:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me - great work @hcarter-775 !
An overview of the testing done on this PR can be seen here: https://smartthings.atlassian.net/wiki/spaces/~62de3b63b6b0b70770d7905d/pages/3317399870/Matter+Thermostat+AQS+Support+Testing
Multiple Air Purifer devices were tested and confirmed to onboard to the correct profile and work correctly on both current (v53) and old (v52) lua libs. Additional regression testing was done with the VDA to ensure other devices in the driver continue to work correctly with these changes.
edit: also, don't forget to squash your commits!
Allows for profiles to be created that use any combination of AQS, thermostat, and fan device types. Also adds a new profile that includes much of this extended functionality. * new cluster definitions imported to thermostat * greater unit conversion inclusion * do_configure logic updated to include aqs and ap + thermostat profiles * added air purifier test cases for unit conversion and device configuration
Allows for profiles to be created that use any combination of AQS, thermostat, and fan device types. Also adds a new profile that includes much of this extended functionality.