Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHAD 13147: Matter Sensor Driver Profiles Cleanup #1466

Merged
merged 5 commits into from
Aug 20, 2024

Conversation

hcarter-775
Copy link
Contributor

@hcarter-775 hcarter-775 commented Jun 20, 2024

Many profiles in the drivers have outdated names that are unable to be mapped to. This change removes or renames outdated profile names to clean up this problem.

Jira ticket can be found here

And this is the superset query that was used to make these decisions: https://superset.samsungiotanalytics.com/superset/sqllab?id=1155

Copy link

github-actions bot commented Jun 20, 2024

Test Results

   61 files    375 suites   0s ⏱️
1 823 tests 1 823 ✅ 0 💤 0 ❌
3 171 runs  3 171 ✅ 0 💤 0 ❌

Results for commit d210e50.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 20, 2024

File Coverage
All files 86%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/init.lua 91%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/air-quality-sensor/init.lua 91%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/embedded-cluster-utils.lua 42%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/smoke-co-alarm/init.lua 83%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against d210e50

@hcarter-775 hcarter-775 force-pushed the CHAD-13147-cleanup-driver-profiles branch from db6bf55 to 4858619 Compare June 20, 2024 15:41
Copy link

github-actions bot commented Jun 20, 2024

Duplicate profile check: Passed - no duplicate profiles detected.

@ctowns ctowns changed the title CHAD 13147 driver profiles cleanup CHAD 13147: Matter Sensor Driver Profiles Cleanup Aug 16, 2024
@hcarter-775
Copy link
Contributor Author

hcarter-775 commented Aug 16, 2024

This is the superset query that was used to make these decisions: https://superset.samsungiotanalytics.com/superset/sqllab?id=1155
cc: @ctowns

Copy link

github-actions bot commented Aug 16, 2024

Channel deleted.

@hcarter-775 hcarter-775 merged commit 11bf263 into main Aug 20, 2024
12 checks passed
@hcarter-775 hcarter-775 deleted the CHAD-13147-cleanup-driver-profiles branch August 20, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants