-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add device configuration for supporting Routine #1458
Conversation
Duplicate profile check: Passed - no duplicate profiles detected. |
Channel deleted. |
Minimum allowed coverage is Generated by 🐒 cobertura-action against c98cd6f |
Is metadata the only way we can support |
Yes, the metadata is the only way to support
I agree with you |
@@ -162,6 +162,8 @@ local function rvc_run_mode_supported_mode_attr_handler(driver, device, ib, resp | |||
) | |||
|
|||
local component = device.profile.components["runMode"] | |||
local labels = get_field_labels_of_supported_modes(device, RVC_RUN_MODE_SUPPORTED_MODES) | |||
device:emit_component_event(component, capabilities.mode.supportedArguments(labels)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the difference between supportedArguments
and supportedModes
?
Also, should this be labels_of_supported_modes
instead of just labels
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The purpose is to use SupportedArguments for the detail view of presentation and use SupportedModes for the Automation. the SupportedArguments are used to dynamically change the mode value that can be selected according to the operation status of the device. And SupportedModes is a full mode list that the device fixedly supports.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HunsupJung can you help me understand what effect this change will have and how I can test it? If I use the Matter VDA to test, what difference should I expect to see with these changes?
Also, do you need to add supportedArguments
for the appliance drivers also?
@ctowns Additionally, The presentation team is preparing patches that the setting that only can be set in |
Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>
254ae73
to
c98cd6f
Compare
In the case of mode capability, presentation is implemented in the list display type.
Therefore, device configuration was added to support automation in the device type that supports the mode capability.