Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusion around UI for uploading labels #282

Closed
JohannaSopraSteria opened this issue Oct 12, 2022 · 10 comments
Closed

Confusion around UI for uploading labels #282

JohannaSopraSteria opened this issue Oct 12, 2022 · 10 comments
Assignees
Labels
bug Something isn't working

Comments

@JohannaSopraSteria
Copy link

JohannaSopraSteria commented Oct 12, 2022

After uploading images, I try to upload my labels.txt file. Once I have selected/dropped it I cannot simply select "Create labels list" nor "Start project" to get started.

The only way I found to use these labels is to select these buttons in the given order:

  1. Start project
  2. Create labels list (labels appear in "Create labels" pane)
  3. Start project

This works, but is quite unintuitive for a new user. To recreate this, I am using COCO images and the corresponding COCO labels.txt file.

image

@SkalskiP
Copy link
Owner

Hi @JohannaSopraSteria! Thank you very much for bringing that to my attention. That one should be easy to fix.

@SkalskiP SkalskiP added the bug Something isn't working label Oct 12, 2022
@SkalskiP SkalskiP self-assigned this Oct 12, 2022
@SkalskiP
Copy link
Owner

@JohannaSopraSteria take a look here - it is a test version of makesense.ai with fixed uploading labels popup. Let me know if everything works. If so, then we will merge it.

@JohannaSopraSteria
Copy link
Author

@SkalskiP This works great if I press Start project after uploading the files, but if I press Create labels list I loose the labels I just uploaded. Still a bit unintuitive for me 😅
image

@SkalskiP
Copy link
Owner

Honestly, that part of Make Sense is really confusing to me. :) Apologies for that.

I 100% agree it would be great if you would not lose the list of labels that you just uploaded when you go from one popup to the other. Problem is that it is technically hard as those popups do not communicate with each other.

This is my proposal for now:

  • Merge the proposed change as the current behavior is obviously a bug.
  • Keep that issue for now as I want to redesign the whole flow for label list definition. I'm not really sure how long that will take as I have a few other things on my plate.

@JohannaSopraSteria
Copy link
Author

JohannaSopraSteria commented Oct 13, 2022

@SkalskiP Perhaps you could just change the text on the "Create labels list" button to "Go back". That way a user will know that they will return to the previous popup and loose their current list, which really is what happens.

@SkalskiP
Copy link
Owner

@JohannaSopraSteria
Copy link
Author

Looks like this to me now:
image
Is this updated?

@SkalskiP
Copy link
Owner

@JohannaSopraSteria sorry it did not rebuild automatically for some reason. I did it manually. You can take a look.

@JohannaSopraSteria
Copy link
Author

@SkalskiP Looks good! 👍

@SkalskiP
Copy link
Owner

Great! So I'm merging that to develop, and similarly to #281, in the near future, those changes will be available at https://develop.makesense.ai/.

As I said earlier. I fully intend to redesign the label names definition popups, but I have at least one new feature to finish before I do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants