From 5e5ee68e8b7dfbdaac30ddc81ef529d513bf9167 Mon Sep 17 00:00:00 2001
From: Rafi <raungar@gmail.com>
Date: Tue, 21 Jan 2020 09:57:19 -0800
Subject: [PATCH] rename redisNotAvailableLogged, simplify conditional logic

---
 src/backend/lib/queue.js | 22 ++++++++++++----------
 1 file changed, 12 insertions(+), 10 deletions(-)

diff --git a/src/backend/lib/queue.js b/src/backend/lib/queue.js
index fcdacce3ca..5c1b2b9fce 100644
--- a/src/backend/lib/queue.js
+++ b/src/backend/lib/queue.js
@@ -9,7 +9,11 @@ const { logger } = require('../utils/logger');
 
 const client = createRedisClient();
 const subscriber = createRedisClient();
-let redisErrorLogged = false;
+
+/**
+ * Tracks whether an informative message has been logged following a Redis connection failure
+ */
+let redisConnectionRefusalLogged = false;
 
 /**
  * Create a Queue with the given `name` (String).
@@ -32,15 +36,13 @@ function createQueue(name) {
   })
     .on('error', err => {
       // An error occurred
-      if (err.code === 'ECONNREFUSED') {
-        if (!redisErrorLogged) {
-          logger.error(
-            '\n\n\t💡  It appears that Redis is not running on your machine.',
-            '\n\t   Please see our documentation for how to install and run Redis:',
-            '\n\t   https://github.com/Seneca-CDOT/telescope/blob/master/docs/CONTRIBUTING.md\n'
-          );
-          redisErrorLogged = true;
-        }
+      if (err.code === 'ECONNREFUSED' && !redisConnectionRefusalLogged) {
+        logger.error(
+          '\n\n\t💡  It appears that Redis is not running on your machine.',
+          '\n\t   Please see our documentation for how to install and run Redis:',
+          '\n\t   https://github.com/Seneca-CDOT/telescope/blob/master/docs/CONTRIBUTING.md\n'
+        );
+        redisConnectionRefusalLogged = true;
       } else {
         logger.error({ err }, `Queue ${name} error`);
       }