From 1512c405c1903cb374ee94aec573bc555e20f61c Mon Sep 17 00:00:00 2001 From: Nikolay Borisenko <22616990+nvborisenko@users.noreply.github.com> Date: Sat, 14 Sep 2024 16:14:06 +0300 Subject: [PATCH 1/3] [dotnet] Workaround using pre-processor directive --- dotnet/src/webdriver/BUILD.bazel | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dotnet/src/webdriver/BUILD.bazel b/dotnet/src/webdriver/BUILD.bazel index dd7f9237b5094..81f50ac5c8444 100644 --- a/dotnet/src/webdriver/BUILD.bazel +++ b/dotnet/src/webdriver/BUILD.bazel @@ -81,6 +81,9 @@ csharp_library( target_frameworks = [ "net8.0", ], + defines = [ + "NET8_0_OR_GREATER" + ], visibility = [ "//dotnet:__subpackages__", ], From a482a6a2a13dba9fc92fe520a424ccdce2278e32 Mon Sep 17 00:00:00 2001 From: Nikolay Borisenko <22616990+nvborisenko@users.noreply.github.com> Date: Sat, 14 Sep 2024 20:45:57 +0300 Subject: [PATCH 2/3] Fix formatting? --- dotnet/src/webdriver/BUILD.bazel | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/dotnet/src/webdriver/BUILD.bazel b/dotnet/src/webdriver/BUILD.bazel index 81f50ac5c8444..3ef1c987dca1c 100644 --- a/dotnet/src/webdriver/BUILD.bazel +++ b/dotnet/src/webdriver/BUILD.bazel @@ -67,6 +67,9 @@ csharp_library( "**/*.cs", ]) + devtools_version_targets(), out = "WebDriver", + defines = [ + "NET8_0_OR_GREATER" + ], internals_visible_to = [ "WebDriver.Common.Tests", ], @@ -81,9 +84,6 @@ csharp_library( target_frameworks = [ "net8.0", ], - defines = [ - "NET8_0_OR_GREATER" - ], visibility = [ "//dotnet:__subpackages__", ], @@ -131,6 +131,9 @@ csharp_library( "**/*.cs", ]) + devtools_version_targets(), out = "WebDriver.StrongNamed", + defines = [ + "NET8_0_OR_GREATER" + ], keyfile = "//dotnet:WebDriver.snk", langversion = "12.0", resources = [ From e2e3c5fe7b6149921edae79fd005cb84b51780e7 Mon Sep 17 00:00:00 2001 From: Nikolay Borisenko <22616990+nvborisenko@users.noreply.github.com> Date: Sat, 14 Sep 2024 20:53:47 +0300 Subject: [PATCH 3/3] Fix formatting --- dotnet/src/webdriver/BUILD.bazel | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dotnet/src/webdriver/BUILD.bazel b/dotnet/src/webdriver/BUILD.bazel index 3ef1c987dca1c..1f23755fa1025 100644 --- a/dotnet/src/webdriver/BUILD.bazel +++ b/dotnet/src/webdriver/BUILD.bazel @@ -68,7 +68,7 @@ csharp_library( ]) + devtools_version_targets(), out = "WebDriver", defines = [ - "NET8_0_OR_GREATER" + "NET8_0_OR_GREATER", ], internals_visible_to = [ "WebDriver.Common.Tests", @@ -132,7 +132,7 @@ csharp_library( ]) + devtools_version_targets(), out = "WebDriver.StrongNamed", defines = [ - "NET8_0_OR_GREATER" + "NET8_0_OR_GREATER", ], keyfile = "//dotnet:WebDriver.snk", langversion = "12.0",