From 8e0574f3e31b903e690bfce5a519a3da580e4b60 Mon Sep 17 00:00:00 2001 From: Nikolay Borisenko <22616990+nvborisenko@users.noreply.github.com> Date: Wed, 15 May 2024 01:19:32 +0300 Subject: [PATCH] Overwrite log file by default --- .../Internal/Logging/FileLogHandler.cs | 2 +- .../Internal/Logging/FileLogHandlerTest.cs | 24 +++++++++---------- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/dotnet/src/webdriver/Internal/Logging/FileLogHandler.cs b/dotnet/src/webdriver/Internal/Logging/FileLogHandler.cs index 774476f32710c..12794aea526b3 100644 --- a/dotnet/src/webdriver/Internal/Logging/FileLogHandler.cs +++ b/dotnet/src/webdriver/Internal/Logging/FileLogHandler.cs @@ -22,7 +22,7 @@ public class FileLogHandler : ILogHandler, IDisposable /// /// The path of the log file. public FileLogHandler(string filePath) - : this(filePath, overwrite: false) + : this(filePath, overwrite: true) { } diff --git a/dotnet/test/common/Internal/Logging/FileLogHandlerTest.cs b/dotnet/test/common/Internal/Logging/FileLogHandlerTest.cs index 716b78c1cda69..dae6cccda01ac 100644 --- a/dotnet/test/common/Internal/Logging/FileLogHandlerTest.cs +++ b/dotnet/test/common/Internal/Logging/FileLogHandlerTest.cs @@ -37,52 +37,52 @@ public void ShouldHandleLogEvent() } [Test] - public void ShouldAppendFileIfDoesNotExist() + public void ShouldCreateFileIfDoesNotExist() { - var tempFilePath = Path.GetTempPath() + "somefile.log"; + var tempFile = Path.GetTempFileName(); try { - using (var fileLogHandler = new FileLogHandler(tempFilePath)) + using (var fileLogHandler = new FileLogHandler(tempFile)) { fileLogHandler.Handle(new LogEvent(typeof(FileLogHandlerTest), DateTimeOffset.Now, LogEventLevel.Info, "test message")); } - using (var fileLogHandler2 = new FileLogHandler(tempFilePath)) + using (var fileLogHandler2 = new FileLogHandler(tempFile)) { fileLogHandler2.Handle(new LogEvent(typeof(FileLogHandlerTest), DateTimeOffset.Now, LogEventLevel.Info, "test message")); } - Assert.That(Regex.Matches(File.ReadAllText(tempFilePath), "test message").Count, Is.EqualTo(2)); + Assert.That(Regex.Matches(File.ReadAllText(tempFile), "test message").Count, Is.EqualTo(1)); } finally { - File.Delete(tempFilePath); + File.Delete(tempFile); } } [Test] public void ShouldAppendFileIfExists() { - var tempFile = Path.GetTempFileName(); + var tempFilePath = Path.GetTempPath() + "somefile.log"; try { - using (var fileLogHandler = new FileLogHandler(tempFile)) + using (var fileLogHandler = new FileLogHandler(tempFilePath)) { fileLogHandler.Handle(new LogEvent(typeof(FileLogHandlerTest), DateTimeOffset.Now, LogEventLevel.Info, "test message")); } - using (var fileLogHandler2 = new FileLogHandler(tempFile)) + using (var fileLogHandler2 = new FileLogHandler(tempFilePath, overwrite: false)) { fileLogHandler2.Handle(new LogEvent(typeof(FileLogHandlerTest), DateTimeOffset.Now, LogEventLevel.Info, "test message")); } - Assert.That(Regex.Matches(File.ReadAllText(tempFile), "test message").Count, Is.EqualTo(2)); + Assert.That(Regex.Matches(File.ReadAllText(tempFilePath), "test message").Count, Is.EqualTo(2)); } finally { - File.Delete(tempFile); + File.Delete(tempFilePath); } } @@ -107,7 +107,7 @@ public void ShouldOverwriteFileIfExists() } [Test] - public void ShouldCreateFileIfDoesNotExist() + public void ShouldAppendFileIfDoesNotExist() { var tempFilePath = Path.GetTempPath() + "somefile.log";