Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core v2 deployment without dataflow-engine is not possible #4939

Closed
Kolajik opened this issue Jun 23, 2023 · 2 comments
Closed

Core v2 deployment without dataflow-engine is not possible #4939

Kolajik opened this issue Jun 23, 2023 · 2 comments
Labels

Comments

@Kolajik
Copy link

Kolajik commented Jun 23, 2023

Describe the bug

I have an issue with deployment of Seldon V2 core components. After this PR #4847 got merged, I have tried to deploy the runtime environment without pipelinegateway and dataflow-engine as we don't need it.

However, upon deploying to our cluster, I have found out that dataflow-engine still gets deployed.

To reproduce

Follow the helm installation guide in Seldon docs - https://docs.seldon.io/projects/seldon-core/en/v2/contents/getting-started/kubernetes-installation/helm.html

  1. Clone the repository as is and checkout v2 branch
  2. Install CRDs in the cluster
    helm install seldon-core-v2-crds ../seldon-core/k8s/helm-charts/seldon-core-v2-crds
  3. Install the clusterwide controller
    helm install seldon-v2-controller ../seldon-core/k8s/helm-charts/seldon-core-v2-setup/ --namespace=seldon-v2 --set controller.clusterwide=true
  4. Install core components, but without pipelinegateway and dataflow-engine
    helm install seldon-v2-runtime ../seldon-core/k8s/helm-charts/seldon-core-v2-runtime/ --namespace=seldon-v2 --set pipelinegateway.disable=true --set dataflow.disable=true
  5. Look inside the cluster which components got deployed
  6. Find out that dataflow-engine is deployed

Expected behaviour

All components except pipelinegateway and dataflow-engine have been deployed.

Environment

  • Cloud Provider: AWS
  • Kubernetes Cluster Version: v1.21.14

Model Details

No model deployed.

@Kolajik Kolajik added the bug label Jun 23, 2023
@Kolajik
Copy link
Author

Kolajik commented Jun 23, 2023

Possibly fixed by #4938. Currently testing.

@Kolajik
Copy link
Author

Kolajik commented Jun 23, 2023

Tested correctly in our cluster. Closing the issue.

@Kolajik Kolajik closed this as completed Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant