Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make fast kronecker matvec behavior more intuitive #10

Open
nchristensen opened this issue Dec 27, 2022 · 1 comment
Open

Make fast kronecker matvec behavior more intuitive #10

nchristensen opened this issue Dec 27, 2022 · 1 comment

Comments

@nchristensen
Copy link
Contributor

nchristensen commented Dec 27, 2022 •
edited
Loading

The existing behavior was based on a Matlab script, but is unintuitive for Python. (I think it has something to do with Matlab using F ordering.) The order of the arguments should also by Sx, Sy, Sz rather than Sz, Sy, Sx to match the standard mathematical notation $S_x \otimes S_y \otimes S_z$
@nchristensen
Copy link
Contributor Author

We should probably also change the function name to avoid collision with Scipy's and Numpy's kron.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nchristensen