Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename parameters in Gaussian and overlap classes #10

Open
Schoyen opened this issue Aug 10, 2022 · 0 comments
Open

Rename parameters in Gaussian and overlap classes #10

Schoyen opened this issue Aug 10, 2022 · 0 comments
Assignees
@Schoyen
Labels
enhancement New feature or request

Comments

@Schoyen
Copy link
Owner

Schoyen commented Aug 10, 2022

The naming of the parameters in the Gaussian (G1D and G2D) and overlap (OD1D and OD2D) classes are naive and confusing. For example, the exponent in the monomial in a G1D-class is called i (named from the "default" value label used in math), but this is confusing when you have g_i.i and g_j.i. Reconsider these names, and change them for all classes.
@Schoyen Schoyen self-assigned this Aug 10, 2022
@Schoyen Schoyen added the enhancement New feature or request label Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Schoyen Schoyen

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Schoyen