Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use xz files instead of gz #17

Merged
merged 1 commit into from
Jan 30, 2019
Merged

Use xz files instead of gz #17

merged 1 commit into from
Jan 30, 2019

Conversation

Schniz
Copy link
Owner

@Schniz Schniz commented Jan 30, 2019

.tar.xz files are usually smaller than .tar.gz, so it'll be faster to download those.

Fixes #7

@Schniz Schniz self-assigned this Jan 30, 2019
@Schniz Schniz merged commit 910ef4d into master Jan 30, 2019
@Schniz Schniz deleted the use-xz-instead-of-gz branch January 30, 2019 12:30
@Schniz Schniz added the PR: New Feature A new feature was added label Feb 18, 2019
@lzhang
Copy link

lzhang commented Dec 28, 2020

Unfortunately this seems to have broken the ability to install certain versions. For example:

https://nodejs.org/dist/v0.10.29/

@ljharb
Copy link

ljharb commented Dec 28, 2020

Indeed, older versions don't have xz builds available.

@Schniz
Copy link
Owner Author

Schniz commented Jan 4, 2021

Unfortunately this seems to have broken the ability to install certain versions. For example:

nodejs.org/dist/v0.10.29

The question is - whether should we support a Node version that isn't supported for more than 4 years. We can add support for .gz, but I don't think it is worth it. We might need to have better errors though.

@lzhang
Copy link

lzhang commented Jan 4, 2021

In my view, the utility of a tool like fnm lies precisely in the ability to switch versions on legacy projects that are using extremely old versions of node. Narrowing version compatibility to marginally speed up decompression seem like a bad tradeoff. That being said, I understand the viewpoint that legacy version support isn't worth the trouble.

Full compatibility goes beyond tar.gz support. I was looking into this a little closer, and I noticed that the directory structure changes over time. Also sometimes only .msi files are available for Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: New Feature A new feature was added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download Node versions with .tar.xz files instead of .tar.gz
3 participants