-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PKCS#1 v1.5 signatures example on docs.rs doesn't work #253
Comments
Note that all of the docs on https://docs.rs are doctested in CI, so in general they will not ever be out-of-date for a given version. The problem is you need the
We should probably add an explicit dependency on |
I couldn't find that in the docs. Thanks for the help. |
tarcieri
added a commit
that referenced
this issue
Jan 20, 2023
We seem to be running into a lot of people who are having trouble with PKCS#1 v1.5 signatures because the failure mode for the `oid` feature of the `sha2` crate being disabled is fairly unscrutable. See #234, #253, and the semi-related tracking issue for #238. If `rsa` has a `sha2` feature, we can always ensure `oid` is enabled, and this can be used in code examples. It also means users don't need two crates to create/verify PKCS#1 v1.5 signatures. RSA is used commonly enough with the SHA2 family that this integration probably makes sense.
tarcieri
added a commit
that referenced
this issue
Jan 20, 2023
We seem to be running into a lot of people who are having trouble with PKCS#1 v1.5 signatures because the failure mode for the `oid` feature of the `sha2` crate being disabled is fairly unscrutable. See #234, #253, and the semi-related tracking issue for #238. If `rsa` has a `sha2` feature, we can always ensure `oid` is enabled, and this can be used in code examples. It also means users don't need two crates to create/verify PKCS#1 v1.5 signatures. RSA is used commonly enough with the SHA2 family that this integration probably makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've been trying to get signing to work, but did not have any luck trying. One of my trouble shooting steps is to create a new rust binary package and try to run this example but it doesn't seem to compile due to an unsatisfied trait bound.
main.rs:
cargo.toml:
Environment:
cargo --version
: cargo 1.65.0 (4bc8f24d3 2022-10-20)Is there something I'm missing here or is the example on docs.rs outdated? Thanks in advance!
The text was updated successfully, but these errors were encountered: