Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove odd file clone on rename #25

Merged
merged 1 commit into from
Mar 30, 2017
Merged

Remove odd file clone on rename #25

merged 1 commit into from
Mar 30, 2017

Conversation

ycherniavskyi
Copy link
Contributor

The previous implementation technically correct, but it breaks plugins metalsmith flow.

For example in my case metalsmith-collections -> metalsmith-jstransformer -> metalsmith-better-excerpts -> metalsmith-jstransformer file objects in collections (created by metalsmith-collections plugin) after clone on rename is dirrefent from file objects in global files collection and as result updating/changing metadata in last one does affect first one, which complitly break the intention of metalsmith-collections plugin.

@RobLoach
Copy link
Contributor

I forget why I did the clone and delete rather then just rename. I remember there was an issue with what you suggest here, but I don't remember exactly what it was.

Let's merge this, and test heavily. I'll make a release of this after we test this a few other places.

Thanks!

@RobLoach RobLoach merged commit 54d0ead into kalamuna:master Mar 30, 2017
@ycherniavskyi ycherniavskyi deleted the remove-odd-file-clone-on-rename branch March 30, 2017 16:52
@ycherniavskyi
Copy link
Contributor Author

ycherniavskyi commented Mar 30, 2017

Thanks. I run tests and they all pass 😄.

@ycherniavskyi
Copy link
Contributor Author

@RobLoach maybe it is time to create next version with last modification and publish it to npm? 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants