Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code overgrabs all contributors to updated threads #14

Closed
RichardLitt opened this issue Oct 14, 2016 · 4 comments
Closed

Code overgrabs all contributors to updated threads #14

RichardLitt opened this issue Oct 14, 2016 · 4 comments

Comments

@RichardLitt
Copy link
Member

If someone comments on a thread three months ago, and someone else comments a day ago, both will be pulled if I am searching within the past week. This is a serious bug that devalues the stats about the size of a community. Each object will need to be date-sorted, not just the top-level issues and PRs.

@RichardLitt
Copy link
Member Author

Assigning to myself for logging purposes, but help would be great if anyone wants to jump in!

@RichardLitt RichardLitt modified the milestone: Polish name-your-contributors Nov 18, 2016
@RichardLitt
Copy link
Member Author

Working on this now.

@RichardLitt
Copy link
Member Author

RichardLitt commented Oct 9, 2017

@tgetgood Not sure this is working. Any ideas?

$ name-your-contributors -u RichardLitt -r name-your-contributors --after=2017-10-06T01:01:01Z
{
  "prCreators": [
    [
      "dignifiedquire",
      "Friedel Ziegelmayer"
    ],
    [
      "jozefizso",
      "Jozef Izso"
    ],
    [
      "greenkeeper",
      null
    ],
    [
      "RichardLitt",
      "Richard Littauer"
    ]
  ],
  "prCommentators": [
    [
      "dignifiedquire",
      "Friedel Ziegelmayer"
    ],
    [
      "RichardLitt",
      "Richard Littauer"
    ],
    [
      "tgetgood",
      "Thomas Getgood"
    ]
  ],
  "issueCreators": [
    [
      "jbenet",
      "Juan Benet"
    ],
    [
      "gr2m",
      "Gregor Martynus"
    ],
    [
      "kentcdodds",
      "Kent C. Dodds"
    ],
    [
      "RichardLitt",
      "Richard Littauer"
    ],
    [
      "jywarren",
      "Jeffrey Warren"
    ],
    [
      "diasdavid",
      "David Dias"
    ],
    [
      "tgetgood",
      "Thomas Getgood"
    ]
  ],
  "issueCommentators": [
    [
      "RichardLitt",
      "Richard Littauer"
    ],
    [
      "gr2m",
      "Gregor Martynus"
    ],
    [
      "kentcdodds",
      "Kent C. Dodds"
    ],
    [
      "jywarren",
      "Jeffrey Warren"
    ],
    [
      "diasdavid",
      "David Dias"
    ]
  ]
}

@RichardLitt RichardLitt removed their assignment Oct 9, 2017
@tgetgood
Copy link
Collaborator

tgetgood commented Oct 10, 2017

The filtering works, the problem is that long options don't. I'll put in a patch for that.

If you try with -a instead of --after I think this works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants