From 855736bdb91962bc29ed6df22cac0e529b5e9f2a Mon Sep 17 00:00:00 2001 From: Remi Gau Date: Thu, 11 May 2023 06:47:32 -0400 Subject: [PATCH 1/2] randomize test order --- run_tests.m | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/run_tests.m b/run_tests.m index e269dce..cdc5cce 100644 --- a/run_tests.m +++ b/run_tests.m @@ -27,7 +27,8 @@ function run_tests() else success = moxunit_runtests(test_folder, ... - '-verbose', '-recursive', '-with_coverage', ... + '-verbose', '-recursive', '-randomize_order', ... + '-with_coverage', ... '-cover', folder_to_cover, ... '-cover_xml_file', 'coverage.xml', ... '-cover_html_dir', fullfile(pwd, 'coverage_html')); From ab71281268fe9fd2f3f8e70c935e780f177068cb Mon Sep 17 00:00:00 2001 From: Remi Gau Date: Thu, 11 May 2023 06:53:26 -0400 Subject: [PATCH 2/2] simplify exiting on failure --- .github/workflows/matlab_test_and_coverage.yaml | 10 ---------- run_tests.m | 10 ++-------- 2 files changed, 2 insertions(+), 18 deletions(-) diff --git a/.github/workflows/matlab_test_and_coverage.yaml b/.github/workflows/matlab_test_and_coverage.yaml index 3a05a58..bc62d13 100644 --- a/.github/workflows/matlab_test_and_coverage.yaml +++ b/.github/workflows/matlab_test_and_coverage.yaml @@ -53,16 +53,6 @@ jobs: with: command: cd(fullfile(getenv('GITHUB_WORKSPACE'), '.github', 'workflows')); run run_tests_ci; - - name: Check logs unix - if: matrix.os == 'ubuntu-latest' || matrix.os == 'macos-latest' - run: grep -q 0 test_report.log || { echo "Some tests failed. Check the 'Run tests' step to know which ones." >&2; exit 1; } - - name: Check logs windows - if: matrix.os == 'windows-latest' - run: | - if (-not (Get-Content test_report.log | Select-String -Pattern "0")) { - throw "Some tests failed. Check the 'Run tests' step to know which ones." - } - - name: Code coverage if: matrix.os == 'ubuntu-latest' || matrix.os == 'macos-latest' uses: codecov/codecov-action@v3 diff --git a/run_tests.m b/run_tests.m index cdc5cce..be3ced6 100644 --- a/run_tests.m +++ b/run_tests.m @@ -34,14 +34,8 @@ function run_tests() '-cover_html_dir', fullfile(pwd, 'coverage_html')); end - fileID = fopen('test_report.log', 'w'); - if success - fprintf(fileID, '0'); - else - fprintf(fileID, '1'); - end - fclose(fileID); - toc; + exit(double(~success)); + end