From 04731656db14d4851c07a2264aac71f6e9a5ba02 Mon Sep 17 00:00:00 2001 From: Roman Hotsiy Date: Tue, 26 Feb 2019 10:02:41 +0200 Subject: [PATCH] fix: escape quotes in string values fixes #882 --- src/utils/jsonToHtml.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/utils/jsonToHtml.ts b/src/utils/jsonToHtml.ts index 73f1a2b482..414c3c76a8 100644 --- a/src/utils/jsonToHtml.ts +++ b/src/utils/jsonToHtml.ts @@ -21,6 +21,10 @@ function htmlEncode(t) { : ''; } +function escapeStringQuotes(str: string) { + return str.replace(/"/g, '\\"'); +} + function decorateWithSpan(value, className) { return '' + htmlEncode(value) + ''; } @@ -53,11 +57,11 @@ function valueToHTML(value) { '' + - htmlEncode(value) + + htmlEncode(escapeStringQuotes(value)) + '' + decorateWithSpan('"', 'token string'); } else { - output += decorateWithSpan('"' + value + '"', 'token string'); + output += decorateWithSpan('"' + escapeStringQuotes(value) + '"', 'token string'); } } else if (valueType === 'boolean') { output += decorateWithSpan(value, 'token boolean');